Page MenuHomePhabricator

Give the Calendar month view a nice hover effect
ClosedPublic

Authored by epriestley on Jul 27 2016, 1:50 PM.
Tags
None
Referenced Files
F18086545: D16334.id39279.diff
Tue, Aug 5, 10:40 PM
F17870518: D16334.id.diff
Mon, Jul 28, 2:09 PM
F17858308: D16334.diff
Sun, Jul 27, 7:27 PM
F17811285: D16334.diff
Fri, Jul 25, 6:23 PM
F17759075: D16334.diff
Tue, Jul 22, 6:01 PM
Unknown Object (File)
Jul 1 2025, 9:39 PM
Unknown Object (File)
Jul 1 2025, 9:34 PM
Unknown Object (File)
Jun 1 2025, 7:39 PM
Subscribers
None

Details

Summary

Ref T11326. Currently, we link Calendar days using hidden DOM nodes.

This is nice because it's simple, and right-clicking a day works properly. However, it's a bit ugly/unintuitive, messy, and unclear. It's especially messy because days are really two different rows, one for events and one for day/week numbers.

Instead, use JS to highlight day cells. You can still right-click by clicking the actual day number, which seems like a reasonable compromise.

Test Plan

Screen Shot 2016-07-27 at 6.44.23 AM.png (225×617 px, 30 KB)

Diff Detail

Repository
rP Phabricator
Branch
cal2
Lint
Lint Warnings
SeverityLocationCodeMessage
Warningwebroot/rsrc/js/application/calendar/behavior-month-view.js:1JAVELIN5`javelinsymbols` Not In Path
Unit
Tests Passed
Build Status
Buildable 13148
Build 16826: Run Core Tests
Build 16825: arc lint + arc unit

Event Timeline

epriestley retitled this revision from to Give the Calendar month view a nice hover effect.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
chad edited edge metadata.
This revision is now accepted and ready to land.Jul 27 2016, 3:49 PM
This revision was automatically updated to reflect the committed changes.