Page MenuHomePhabricator
Differential D16265

Fix mobile menu for files in Differential Changesets
ClosedPublic
Actions

Authored by chad on Jul 9 2016, 8:55 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, May 10, 6:03 AM
Unknown Object (File)
Mon, Apr 28, 4:46 AM
Unknown Object (File)
Apr 15 2025, 12:08 PM
Unknown Object (File)
Mar 29 2025, 11:38 AM
Unknown Object (File)
Mar 28 2025, 4:52 AM
Unknown Object (File)
Feb 25 2025, 6:30 AM
Unknown Object (File)
Feb 25 2025, 6:29 AM
Unknown Object (File)
Feb 21 2025, 1:28 AM
View All Files
Subscribers
Korvin

Details

Reviewers
epriestley
Maniphest Tasks
T7754: View Options Menu doesn't stay relative to the button
T11305: 'View Options' in Differential reviews is badly aligned on narrow mobile screens
Commits
rPe2d195e03ab0: Fix mobile menu for files in Differential Changesets
Summary

Fixes T11305, Ref T7754. Makes this menu dropdown act like actions and collapse to a fa-bars menu.

Test Plan

View on mobile, desktop, browser. Click an action, spawn new page.

pasted_file (440×474 px, 106 KB)

Diff Detail

Repository
rP Phabricator
Branch
diff-menu (branched from master)
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 13004
Build 16614: Run Core Tests
Build 16613: arc lint + arc unit

Event Timeline

chad updated this revision to Diff 39126.Jul 9 2016, 8:55 PM
chad retitled this revision from to Fix mobile menu for files in Differential Changesets.
chad updated this object.
chad edited the test plan for this revision. (Show Details)
chad added a reviewer: epriestley.
chad added tasks: T11305: 'View Options' in Differential reviews is badly aligned on narrow mobile screens, T7754: View Options Menu doesn't stay relative to the button.
Herald added a subscriber: Korvin. · View Herald TranscriptJul 9 2016, 8:55 PM
chad edited the test plan for this revision. (Show Details)Jul 9 2016, 8:56 PM
epriestley accepted this revision.Jul 9 2016, 9:20 PM
epriestley edited edge metadata.
This revision is now accepted and ready to land.Jul 9 2016, 9:20 PM
Closed by commit rPe2d195e03ab0: Fix mobile menu for files in Differential Changesets (authored by chad, committed by chad). · Explain WhyJul 9 2016, 9:25 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
resources/
celerity/
12 lines
src/
applications/
differential/
view/
20 lines
webroot/
rsrc/
css/
application/
differential/
9 lines

Diff 39126

View Options

resources/celerity/map.php

Loading...
View Options

src/applications/differential/view/DifferentialChangesetListView.php

Loading...
View Options

webroot/rsrc/css/application/differential/changeset-view.css

Loading...
Phabricator · Built by Phacility