Page MenuHomePhabricator
Differential D16258

Strip timestamps from popup notification bubbles
ClosedPublic
Actions

Authored by epriestley on Jul 8 2016, 2:41 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Jan 29, 8:01 PM
Unknown Object (File)
Mon, Jan 27, 10:43 AM
Unknown Object (File)
Fri, Jan 24, 2:39 PM
Unknown Object (File)
Fri, Jan 24, 2:39 PM
Unknown Object (File)
Fri, Jan 24, 2:39 PM
Unknown Object (File)
Fri, Jan 24, 2:39 PM
Unknown Object (File)
Thu, Jan 23, 8:43 PM
Unknown Object (File)
Tue, Jan 21, 9:24 AM
View All Files
Subscribers
None

Details

Reviewers
chad
Maniphest Tasks
T11097: Pop-up notifications picked up a timestamp as a side effect
Commits
rPbd6d300282ec: Strip timestamps from popup notification bubbles
Summary

Fixes T11097. Currently, popup notifications show a useless timestamp with the current time, after D16041 made some things more consistent.

Strip these from the popup bubbles.

Test Plan
  • Saw a popup bubble, no timestamp.
  • Viewed main notification list, saw timestamps.

Diff Detail

Repository
rP Phabricator
Branch
notify1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 12979
Build 16575: Run Core Tests
Build 16574: arc lint + arc unit

Event Timeline

epriestley updated this revision to Diff 39105.Jul 8 2016, 2:41 PM
epriestley retitled this revision from to Strip timestamps from popup notification bubbles.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
epriestley added a task: T11097: Pop-up notifications picked up a timestamp as a side effect.
chad accepted this revision.Jul 8 2016, 2:45 PM
chad edited edge metadata.
This revision is now accepted and ready to land.Jul 8 2016, 2:45 PM
Closed by commit rPbd6d300282ec: Strip timestamps from popup notification bubbles (authored by epriestley, committed by epriestley). · Explain WhyJul 8 2016, 2:46 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
applications/
notification/
builder/
13 lines
controller/
3 lines
view/
phui/
37 lines

Diff 39105

View Options

src/applications/notification/builder/PhabricatorNotificationBuilder.php

Loading...
View Options

src/applications/notification/controller/PhabricatorNotificationIndividualController.php

Loading...
View Options

src/view/phui/PHUIFeedStoryView.php

Loading...
Phabricator · Built by Phacility