Page MenuHomePhabricator

Make links to hidden comments work (Fixes T11117)
ClosedPublic

Authored by isfs on Jul 8 2016, 1:20 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Dec 21, 5:39 PM
Unknown Object (File)
Thu, Dec 19, 6:50 AM
Unknown Object (File)
Sun, Dec 15, 4:05 PM
Unknown Object (File)
Thu, Dec 12, 10:34 PM
Unknown Object (File)
Thu, Dec 12, 10:34 PM
Unknown Object (File)
Tue, Dec 10, 7:29 PM
Unknown Object (File)
Mon, Dec 9, 12:10 PM
Unknown Object (File)
Sun, Dec 8, 1:02 PM
Subscribers

Diff Detail

Repository
rP Phabricator
Branch
hidden-anchor-fix
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 12974
Build 16568: arc lint + arc unit

Event Timeline

isfs retitled this revision from to Make links to hidden comments work (Fixes T11117).
isfs updated this object.
isfs edited the test plan for this revision. (Show Details)
isfs added a reviewer: epriestley.
epriestley edited edge metadata.

Thanks!

I've added you to Blessed Committers so you should be able to land this yourself. See that project description for help if you have trouble.

(I also added you to Community.)

This revision is now accepted and ready to land.Jul 8 2016, 2:23 PM

Thanks, @epriestley. Just one question: I note that resources/celerity/map.php is in the repository, though it is auto-generated, and that changes to it seem to be incorporated with other changes (i.e. not separate commits from CI). Therefore, should I rebase this onto current master and run bin/celerity map before landing, or something like that?

chad requested changes to this revision.Jul 9 2016, 6:18 AM
chad added a reviewer: chad.
chad added a subscriber: chad.

rebase to master, run bin/celerity map, then commit the map update. This change should have included a new map file. thanks!

This revision now requires changes to proceed.Jul 9 2016, 6:18 AM
isfs edited edge metadata.

Rebased to master and updated resources/celerity/map.php

chad edited edge metadata.
This revision is now accepted and ready to land.Jul 9 2016, 2:32 PM
This revision was automatically updated to reflect the committed changes.
This revision was automatically updated to reflect the committed changes.

There were a few intervening commits, which surely would be normal following a review process (?), but I note that arc land has merged my change into current master rather than rebasing it onto current master. As there don't appear to be merge changesets everywhere in the repository, this doesn't seem to be the norm. Did I do something wrong? I just ran arc land hidden-anchor-fix as instructed by 'Next Step' in the web UI. Should I have instead pushed the 'Land Revision' link in the UI, or rebased manually immediately prior to landing, or something else? Would be handy to know in case some of my other work gets accepted. :-)