This Fixes T11117.
Details
Details
Diff Detail
Diff Detail
- Repository
- rP Phabricator
- Branch
- hidden-anchor-fix
- Lint
Lint Passed - Unit
No Test Coverage - Build Status
Buildable 12995 Build 16601: Run Core Tests Build 16600: arc lint + arc unit
| Time | Test | |
|---|---|---|
| 63 ms | PhabricatorProjectCoreTestCase::Unknown Unit Message (" ") Assertion failed, expected 'true' (at PhabricatorProjectCoreTestCase.php:1118).
ACTUAL VALUE
| |
| 0 ms | AlmanacNamesTestCase::Unknown Unit Message (" ") 30 assertions passed. | |
| 0 ms | AlmanacServiceTypeTestCase::Unknown Unit Message (" ") 1 assertion passed. | |
| 0 ms | AphrontHTTPSinkTestCase::Unknown Unit Message (" ") 2 assertions passed. | |
| 0 ms | AphrontHTTPSinkTestCase::Unknown Unit Message (" ") 6 assertions passed. | |
| View Full Test Results (1 Failed · 319 Passed) |
Event Timeline
Comment Actions
Thanks!
I've added you to Blessed Committers so you should be able to land this yourself. See that project description for help if you have trouble.
(I also added you to Community.)
Comment Actions
Thanks, @epriestley. Just one question: I note that resources/celerity/map.php is in the repository, though it is auto-generated, and that changes to it seem to be incorporated with other changes (i.e. not separate commits from CI). Therefore, should I rebase this onto current master and run bin/celerity map before landing, or something like that?
Comment Actions
rebase to master, run bin/celerity map, then commit the map update. This change should have included a new map file. thanks!
Comment Actions
There were a few intervening commits, which surely would be normal following a review process (?), but I note that arc land has merged my change into current master rather than rebasing it onto current master. As there don't appear to be merge changesets everywhere in the repository, this doesn't seem to be the norm. Did I do something wrong? I just ran arc land hidden-anchor-fix as instructed by 'Next Step' in the web UI. Should I have instead pushed the 'Land Revision' link in the UI, or rebased manually immediately prior to landing, or something else? Would be handy to know in case some of my other work gets accepted. :-)