Differential D16245

Clean up Blog Post crumbs
ClosedPublic
Actions

Authored by chad on Jul 7 2016, 1:13 AM.

Details

Reviewers

epriestley

Maniphest Tasks

T9360: Unbeta Phame

Commits

rP0dd6c3653edf: Clean up Blog Post crumbs

Summary

Show the J monogram when internally linked, but nothing externally (cleaner UI). Ref T9360

Test Plan

View post live and internal.

Diff Detail

Repository

rP Phabricator

Branch

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 12954
Build 16536: Run Core Tests
Build 16535: arc lint + arc unit

Event Timeline

chad updated this revision to Diff 39078.Jul 7 2016, 1:13 AM

chad retitled this revision from to Clean up Blog Post crumbs..

chad updated this object.

chad edited the test plan for this revision. (Show Details)

chad added a reviewer: epriestley.

chad added a task: T9360: Unbeta Phame.

Herald added a subscriber: Korvin. · View Herald TranscriptJul 7 2016, 1:14 AM

epriestley accepted this revision.Jul 7 2016, 1:21 AM

epriestley edited edge metadata.

This revision is now accepted and ready to land.Jul 7 2016, 1:21 AM

chad retitled this revision from Clean up Blog Post crumbs. to Clean up Blog Post crumbs.Jul 7 2016, 1:30 AM

chad edited edge metadata.

Closed by commit rP0dd6c3653edf: Clean up Blog Post crumbs (authored by chad, committed by chad). · Explain WhyJul 7 2016, 1:30 AM

This revision was automatically updated to reflect the committed changes.

epriestley mentioned this in D14654: Unbeta Phame.Jul 7 2016, 1:56 AM

chad added inline comments.Jul 7 2016, 1:57 AM

src/applications/phame/application/PhabricatorPhameApplication.php
34–37 ↗	(On Diff #39079)	whelp

epriestley awarded a token.Jul 7 2016, 1:57 AM

i landed this from the web too, so something was really borked locally.

Revision Contents
Changeset List

Path

Size

src/

applications/

phame/

controller/

PhameLiveController.php

4 lines

Diff 39078

View Options

src/applications/phame/controller/PhameLiveController.php

Clean up Blog Post crumbsClosedPublicActions