Page MenuHomePhabricator

Unbeta Phame
AbandonedPublic

Authored by chad on Dec 3 2015, 8:08 PM.

Details

Summary

After next stable cut, perhaps. I think its ready enough. Fixes T9360, Fixes T9895

Test Plan

view app

Diff Detail

Repository
rP Phabricator
Branch
arcpatch-D14654
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 12959
Build 16544: Run Core Tests
Build 16543: arc lint + arc unit

Event Timeline

chad retitled this revision from to Unbeta Phame.
chad updated this object.
chad edited the test plan for this revision. (Show Details)
chad added a reviewer: epriestley.

curious, any reason not to land this?

T9897 has the list of things we want to fix before moving Phame out of prototype.

I think this is mostly blocked on me and on custom domains needing some rework to really be usable.

chad edited edge metadata.
  • Update docs

Some of this language in the doc feels a bit weird and out of date with modern tone/focus, let me take a quick pass at it.

I'll caveat custom domains, too.

epriestley edited edge metadata.

D16246 for alternate docs.

This revision is now accepted and ready to land.Jul 7 2016, 1:40 AM
chad edited edge metadata.
  • Update docs

(This looks flipped -- should just be removing isPrototype()?)

somethings messed up locally.

I don't see isPrototype... so .... huzzah?

Oh, the earlier version of this snuck into D16245. Looks like we're good now, since D16246 just overwrote the docs anyway.