Ref T9360. Moves PhamePost to CommentEditEngine.
- HTTP Parameters dropdown on New Post goes to 404
- Implement EditEngine Comments
Details
Details
- Reviewers
epriestley - Maniphest Tasks
- T9360: Unbeta Phame
- Commits
- rP15f9e0f6ea2f: Use CommentEditEngine in PhamePost
Make Post, Make Comment, Laugh.
Diff Detail
Diff Detail
- Repository
- rP Phabricator
- Branch
- phame-edit-comment
- Lint
Lint Passed - Unit
Tests Passed - Build Status
Buildable 12904 Build 16460: Run Core Tests Build 16459: arc lint + arc unit
Event Timeline
Comment Actions
The 404 is:
core.pkg.js:2326 POST http://local.phacility.com/phame/edit/1/comment/ 404 (Not Found)
So seems to not find phame/post/edit. Not sure if my fault.
Comment Actions
Slightly weird that we quote like this, but "POSTxxx" isn't a real monogram so it doesn't link:
Not sure if that's worth fixing or how to fix it:
- I could make it not show the "quote" action if you don't setQuoteRef(), although quoting post comments seems somewhat useful.
- We could also make "POST" a real monogram. I think I'd use monograms for posts (see earlier in T9897#151198), although multiple-letter monograms feel a little clunky to me.
- We could give posts the "J" monogram, nominally for "Journal Entry"?
I maybe slightly favor giving them "J".
Also slightly weird that you can select "Change Projects" and "Change Subscribers", and we show you a preview, and we actually do apply the actions, but the timeline doesn't show them. Maybe:
- Show comments, subscriber changes, and project changes in the timeline?
- Or, I can tweak things so the actions just don't show up here?
I maybe slightly favor removing the actions.
Comment Actions
Oh I made POST work, but didn’t push up another diff. I can just get rid of
actions too.