Page MenuHomePhabricator

Don't load the entire graph for tasks
ClosedPublic

Authored by epriestley on Jul 1 2016, 6:41 PM.
Tags
None
Referenced Files
F14036984: D16218.id39016.diff
Sun, Nov 10, 1:16 PM
F14021913: D16218.diff
Wed, Nov 6, 1:53 PM
F13998624: D16218.diff
Thu, Oct 24, 10:18 AM
F13977545: D16218.id39015.diff
Fri, Oct 18, 7:05 PM
Unknown Object (File)
Sun, Oct 13, 4:49 AM
Unknown Object (File)
Sep 20 2024, 2:24 PM
Unknown Object (File)
Sep 20 2024, 12:31 PM
Unknown Object (File)
Sep 14 2024, 4:57 PM
Subscribers
None

Details

Summary

Ref T4788. As it turns out, our tasks are very tightly connected.

Instead of loading every parent/child task, then every parent/child of those tasks, etc., etc., only load tasks in the "same direction" that we're already heading.

For example, we load children of children, but not parents of children. And we load parents of parents, but not children of parents.

Basically we only go "up" and "down" now, but not "out" as much. This should reduce the gigantic multiple-thousand-node graphs currently shown in the UI.

I still discover the whole graph for revisiosn, because I think it's probably more useful and always much smaller. That might need adjustment too, though.

Test Plan

Seems fine locally??

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley retitled this revision from to Don't load the entire graph for tasks.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
chad edited edge metadata.
This revision is now accepted and ready to land.Jul 1 2016, 6:42 PM
This revision was automatically updated to reflect the committed changes.