Page MenuHomePhabricator

Build that thing someone posted a screenshot of on Facebook
ClosedPublic

Authored by epriestley on Jul 1 2016, 1:44 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Dec 22, 10:36 AM
Unknown Object (File)
Sun, Dec 22, 10:36 AM
Unknown Object (File)
Wed, Dec 18, 7:52 AM
Unknown Object (File)
Wed, Dec 18, 1:19 AM
Unknown Object (File)
Tue, Dec 17, 3:44 AM
Unknown Object (File)
Mon, Dec 16, 7:14 PM
Unknown Object (File)
Mon, Dec 16, 6:02 PM
Unknown Object (File)
Fri, Dec 13, 3:10 AM
Subscribers
None

Details

Summary

Seemed kinda cool.

Test Plan

Screen Shot 2016-06-30 at 6.36.26 PM.png (423×493 px, 51 KB)

Diff Detail

Repository
rP Phabricator
Branch
tabs6
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 12864
Build 16402: Run Core Tests
Build 16401: arc lint + arc unit

Event Timeline

epriestley retitled this revision from to Build that thing someone posted a screenshot of on Facebook.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.

maybe we need a bucket of water

for putting fires out :)

Tabs should have a means of setting a color/error/warning, I think? The token looks a little odd offhand.

epriestley edited edge metadata.
  • Use tab color instead.

Screen Shot 2016-06-30 at 7.39.09 PM.png (350×464 px, 43 KB)

chad edited edge metadata.
This revision is now accepted and ready to land.Jul 1 2016, 3:22 AM
This revision was automatically updated to reflect the committed changes.