Page MenuHomePhabricator
Differential D16210

Build that thing someone posted a screenshot of on Facebook
ClosedPublic
Actions

Authored by epriestley on Jul 1 2016, 1:44 AM.
Tags
None
Referenced Files
Unknown Object (File)
Oct 10 2024, 5:14 PM
Unknown Object (File)
Sep 15 2024, 7:41 AM
Unknown Object (File)
Sep 7 2024, 6:07 AM
Unknown Object (File)
Sep 4 2024, 1:06 AM
Unknown Object (File)
Sep 3 2024, 9:29 PM
Unknown Object (File)
Aug 28 2024, 11:28 PM
Unknown Object (File)
Aug 25 2024, 12:34 PM
Unknown Object (File)
Aug 25 2024, 12:34 PM
View All Files
Subscribers
None

Details

Reviewers
chad
Commits
rPdc37789d530f: Build that thing someone posted a screenshot of on Facebook
Summary

Seemed kinda cool.

Test Plan

Screen Shot 2016-06-30 at 6.36.26 PM.png (423×493 px, 51 KB)

Diff Detail

Repository
rP Phabricator
Branch
tabs6
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 12864
Build 16402: Run Core Tests
Build 16401: arc lint + arc unit

Event Timeline

epriestley updated this revision to Diff 38987.Jul 1 2016, 1:44 AM
epriestley retitled this revision from to Build that thing someone posted a screenshot of on Facebook.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
chad edited edge metadata.Jul 1 2016, 1:44 AM

pasted_file (74×77 px, 2 KB)

epriestley added a comment.Jul 1 2016, 1:51 AM

maybe we need a bucket of water

for putting fires out :)

chad added a comment.Jul 1 2016, 2:23 AM

Tabs should have a means of setting a color/error/warning, I think? The token looks a little odd offhand.

epriestley updated this revision to Diff 38993.Jul 1 2016, 2:39 AM
epriestley edited edge metadata.
  • Use tab color instead.

Screen Shot 2016-06-30 at 7.39.09 PM.png (350×464 px, 43 KB)

chad accepted this revision.Jul 1 2016, 3:22 AM
chad edited edge metadata.
This revision is now accepted and ready to land.Jul 1 2016, 3:22 AM
Closed by commit rPdc37789d530f: Build that thing someone posted a screenshot of on Facebook (authored by epriestley, committed by epriestley). · Explain WhyJul 1 2016, 11:36 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
4 lines
applications/
differential/
controller/
164 lines
customfield/
18 lines
18 lines
edge/
58 lines
storage/
29 lines
view/
31 lines
diffusion/
view/
167 lines
infrastructure/
diff/
view/
171 lines

Diff 38987

View Options

src/__phutil_library_map__.php

Loading...
View Options

src/applications/differential/controller/DifferentialRevisionViewController.php

Loading...
View Options

src/applications/differential/customfield/DifferentialChildRevisionsField.php

Loading...
View Options

src/applications/differential/customfield/DifferentialParentRevisionsField.php

Loading...
View Options

src/applications/differential/edge/DifferentialStackGraph.php

Loading...
View Options

src/applications/differential/storage/DifferentialRevision.php

Loading...
View Options

src/applications/differential/view/DifferentialRevisionListView.php

Loading...
View Options

src/applications/diffusion/view/DiffusionHistoryTableView.php

Loading...
View Options

src/infrastructure/diff/view/PHUIDiffGraphView.php

Loading...
Phabricator · Built by Phacility