Page MenuHomePhabricator
Differential D16209

Merge "Table of Contents", "Local Commits", "Update History" and "Similar Revisions"
ClosedPublic
Actions

Authored by epriestley on Jul 1 2016, 12:17 AM.
Tags
None
Referenced Files
F15425865: D16209.id38986.diff
Sun, Mar 23, 6:29 AM
F15425051: D16209.id38992.diff
Sun, Mar 23, 2:13 AM
F15416007: D16209.diff
Thu, Mar 20, 8:38 AM
F15415900: D16209.id38986.diff
Thu, Mar 20, 8:19 AM
F15381763: D16209.id38986.diff
Fri, Mar 14, 9:16 AM
F15302821: D16209.diff
Wed, Mar 5, 10:27 PM
Unknown Object (File)
Feb 9 2025, 1:55 AM
Unknown Object (File)
Feb 9 2025, 1:55 AM
View All Files
Subscribers
None

Details

Reviewers
chad
Maniphest Tasks
T10628: Merge "Local Commits" and "Open Revisions Affecting These Files" into tabs on "Revision Update History" in Differential
Commits
rP6c7e392f8936: Merge "Table of Contents", "Local Commits", "Update History" and "Similar…
Summary

Ref T10628. Turn these into tabs in a single box, since "local commits" and "similar revisions" are of particularly rare use.

Test Plan

Screen Shot 2016-06-30 at 5.15.06 PM.png (415×1 px, 76 KB)

Diff Detail

Repository
rP Phabricator
Branch
tabs5
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 12863
Build 16400: Run Core Tests
Build 16399: arc lint + arc unit

Event Timeline

epriestley updated this revision to Diff 38986.Jul 1 2016, 12:17 AM
epriestley retitled this revision from to Merge "Table of Contents", "Local Commits", "Update History" and "Similar Revisions".
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
epriestley added a task: T10628: Merge "Local Commits" and "Open Revisions Affecting These Files" into tabs on "Revision Update History" in Differential.
chad accepted this revision.Jul 1 2016, 1:31 AM
chad edited edge metadata.
This revision is now accepted and ready to land.Jul 1 2016, 1:31 AM
Closed by commit rP6c7e392f8936: Merge "Table of Contents", "Local Commits", "Update History" and "Similar… (authored by epriestley, committed by epriestley). · Explain WhyJul 1 2016, 1:51 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
applications/
differential/
controller/
4 lines
55 lines
view/
5 lines
5 lines
infrastructure/
diff/
view/
14 lines

Diff 38986

View Options

src/applications/differential/controller/DifferentialController.php

Loading...
View Options

src/applications/differential/controller/DifferentialRevisionViewController.php

Loading...
View Options

src/applications/differential/view/DifferentialLocalCommitsView.php

Loading...
View Options

src/applications/differential/view/DifferentialRevisionUpdateHistoryView.php

Loading...
View Options

src/infrastructure/diff/view/PHUIDiffTableOfContentsListView.php

Loading...
Phabricator · Built by Phacility