Page MenuHomePhabricator
Differential D16208

Remove old ObjectBox tab cruft
ClosedPublic
Actions

Authored by epriestley on Jul 1 2016, 12:01 AM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Jan 30, 1:56 PM
Unknown Object (File)
Fri, Jan 24, 2:27 PM
Unknown Object (File)
Fri, Jan 24, 2:27 PM
Unknown Object (File)
Fri, Jan 24, 2:27 PM
Unknown Object (File)
Wed, Jan 22, 2:45 AM
Unknown Object (File)
Tue, Jan 21, 7:59 PM
Unknown Object (File)
Tue, Jan 21, 11:50 AM
Unknown Object (File)
Tue, Jan 21, 9:55 AM
View All Files
Subscribers
None

Details

Reviewers
chad
Maniphest Tasks
T10628: Merge "Local Commits" and "Open Revisions Affecting These Files" into tabs on "Revision Update History" in Differential
Commits
rP2c43d055b191: Remove old ObjectBox tab cruft
Summary

Ref T10628. Cleans up remaining weird, unused tab behaviors in ObjectBoxView to simplify ObjectBox.

Test Plan

Toggled tabs in Files.

Diff Detail

Repository
rP Phabricator
Branch
tabs4
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 12862
Build 16398: Run Core Tests
Build 16397: arc lint + arc unit

Event Timeline

epriestley updated this revision to Diff 38985.Jul 1 2016, 12:01 AM
epriestley retitled this revision from to Remove old ObjectBox tab cruft.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
epriestley added a task: T10628: Merge "Local Commits" and "Open Revisions Affecting These Files" into tabs on "Revision Update History" in Differential.
chad accepted this revision.Jul 1 2016, 1:28 AM
chad edited edge metadata.
This revision is now accepted and ready to land.Jul 1 2016, 1:28 AM
Closed by commit rP2c43d055b191: Remove old ObjectBox tab cruft (authored by epriestley, committed by epriestley). · Explain WhyJul 1 2016, 1:50 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
resources/
celerity/
14 lines
src/
view/
phui/
146 lines
4 lines
2 lines
webroot/
rsrc/
js/
phui/
behavior-phui-tab-group.js
behavior-phui-object-box-tabs.js
18 lines

Diff 38985

View Options

resources/celerity/map.php

Loading...
View Options

src/view/phui/PHUIObjectBoxView.php

Loading...
View Options

src/view/phui/PHUITabGroupView.php

Loading...
View Options

src/view/phui/PHUITabView.php

Loading...
View Options

webroot/rsrc/js/phui/behavior-phui-object-box-tabs.js

Loading...
View Options

webroot/rsrc/js/phui/behavior-phui-tab-group.js

Loading...
Phabricator · Built by Phacility