Ref T9360. This adds ability to search posts by blog(s) and by type better.
Details
Details
- Reviewers
epriestley - Maniphest Tasks
- T9360: Unbeta Phame
- Commits
- rP23ec515afc1d: Improve PhamePost search options
Create some posts, search for them.
Diff Detail
Diff Detail
- Repository
- rP Phabricator
- Branch
- phame-typeahead (branched from master)
- Lint
Lint Passed - Unit
Tests Passed - Build Status
Buildable 12849 Build 16375: Run Core Tests Build 16374: arc lint + arc unit
Event Timeline
| src/applications/phame/controller/blog/PhameBlogViewController.php | ||
|---|---|---|
| 147 | Probably just blog= works, too. | |
| src/applications/phame/query/PhamePostSearchEngine.php | ||
| 24–26 | (This would become "blogPHIDs" with the change below.) | |
| 46 | Maybe use blogPHIDs as the key, and 'blog', 'blogs', 'blogPHID' as the aliases. | |
| 48 | Minor, but maybe "on certain blogs" instead of "with certain blogs"? | |
| src/applications/phame/query/PhamePostSearchEngine.php | ||
|---|---|---|
| 46 | oohh, that what alias does. nice. | |
Comment Actions
Yeah, the "aliases" thing is basically just "anything a somewhat-reasonable user might try to type into the URL to select this field", and the "key" is what we actually store in the database.
(In some apps it also does "things we used to make you type into the URL that should probably still keep working".)