Page MenuHomePhabricator

Improve PhamePost search options
ClosedPublic

Authored by chad on Jun 30 2016, 4:19 AM.
Tags
None
Referenced Files
F12837287: D16199.diff
Thu, Mar 28, 4:49 PM
Unknown Object (File)
Wed, Mar 27, 5:41 PM
Unknown Object (File)
Wed, Mar 20, 6:56 AM
Unknown Object (File)
Sun, Mar 10, 11:52 AM
Unknown Object (File)
Feb 28 2024, 8:05 AM
Unknown Object (File)
Feb 3 2024, 11:08 AM
Unknown Object (File)
Jan 28 2024, 9:09 PM
Unknown Object (File)
Jan 28 2024, 9:09 PM
Subscribers

Details

Summary

Ref T9360. This adds ability to search posts by blog(s) and by type better.

Test Plan

Create some posts, search for them.

pasted_file (662×1 px, 141 KB)

Diff Detail

Repository
rP Phabricator
Branch
phame-typeahead (branched from master)
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 12851
Build 16379: Run Core Tests
Build 16378: arc lint + arc unit

Event Timeline

chad retitled this revision from to Improve PhamePost search options.
chad updated this object.
chad edited the test plan for this revision. (Show Details)
chad added a reviewer: epriestley.
chad added a task: T9360: Unbeta Phame.
  • Add ability to "Search Posts" from Blog View
epriestley edited edge metadata.
epriestley added inline comments.
src/applications/phame/controller/blog/PhameBlogViewController.php
147

Probably just blog= works, too.

src/applications/phame/query/PhamePostSearchEngine.php
24–26

(This would become "blogPHIDs" with the change below.)

46

Maybe use blogPHIDs as the key, and 'blog', 'blogs', 'blogPHID' as the aliases.

48

Minor, but maybe "on certain blogs" instead of "with certain blogs"?

This revision is now accepted and ready to land.Jun 30 2016, 7:47 PM
chad edited edge metadata.
  • derp
chad marked an inline comment as done.Jun 30 2016, 7:51 PM
chad added inline comments.
src/applications/phame/query/PhamePostSearchEngine.php
46

oohh, that what alias does. nice.

Yeah, the "aliases" thing is basically just "anything a somewhat-reasonable user might try to type into the URL to select this field", and the "key" is what we actually store in the database.

(In some apps it also does "things we used to make you type into the URL that should probably still keep working".)

chad marked 5 inline comments as done.
  • per comments
This revision was automatically updated to reflect the committed changes.