Page MenuHomePhabricator
Differential D16197

Misc Phame cleanup
ClosedPublic
Actions

Authored by chad on Jun 30 2016, 12:53 AM.
Tags
None
Referenced Files
F15458276: D16197.id38960.diff
Sun, Mar 30, 10:30 PM
F15457759: D16197.id38959.diff
Sun, Mar 30, 6:32 PM
F15448952: D16197.id.diff
Fri, Mar 28, 7:51 AM
F15441220: D16197.diff
Wed, Mar 26, 4:57 PM
F15376286: D16197.diff
Thu, Mar 13, 2:45 AM
F15311874: D16197.id38959.diff
Thu, Mar 6, 11:53 AM
F15311235: D16197.id38960.diff
Mar 6 2025, 9:53 AM
F15302925: D16197.diff
Mar 5 2025, 11:57 PM
View All Files
Subscribers
Korvin

Details

Reviewers
epriestley
Maniphest Tasks
T9360: Unbeta Phame
Commits
rPfd0a606f7942: Misc Phame cleanup
Summary

Ref T9360.

  • View Live useless on archived blogs
  • Edit Blog Image treatment like profiles
  • Pager next/prev should keep you on whatever view you're on
  • Unset user titles aren't falling back properly
  • Add captions to edit fields for better clarification
Test Plan

Archive a blog, Edit a photo, verify pager on live and internal blogs, check empty titles, and view new edit form instructions.

Diff Detail

Repository
rP Phabricator
Branch
phame-2 (branched from master)
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 12836
Build 16355: Run Core Tests
Build 16354: arc lint + arc unit

Event Timeline

chad updated this revision to Diff 38959.Jun 30 2016, 12:53 AM
chad retitled this revision from to Misc Phame cleanup.
chad updated this object.
chad edited the test plan for this revision. (Show Details)
chad added a reviewer: epriestley.
chad added a task: T9360: Unbeta Phame.
Herald added a subscriber: Korvin. · View Herald TranscriptJun 30 2016, 12:53 AM
epriestley accepted this revision.Jun 30 2016, 1:52 AM
epriestley edited edge metadata.
This revision is now accepted and ready to land.Jun 30 2016, 1:52 AM
Closed by commit rPfd0a606f7942: Misc Phame cleanup (authored by chad, committed by chad). · Explain WhyJun 30 2016, 2:08 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
applications/
phame/
controller/
blog/
13 lines
post/
10 lines
editor/
8 lines
storage/
12 lines

Diff 38959

View Options

src/applications/phame/controller/blog/PhameBlogManageController.php

Loading...
View Options

src/applications/phame/controller/post/PhamePostViewController.php

Loading...
View Options

src/applications/phame/editor/PhameBlogEditEngine.php

Loading...
View Options

src/applications/phame/storage/PhamePost.php

Loading...
Phabricator · Built by Phacility