Page MenuHomePhabricator

Misc Phame cleanup
ClosedPublic

Authored by chad on Jun 30 2016, 12:53 AM.
Tags
None
Referenced Files
F12836836: D16197.id38959.diff
Thu, Mar 28, 4:11 PM
Unknown Object (File)
Sat, Mar 16, 3:11 PM
Unknown Object (File)
Feb 3 2024, 11:07 AM
Unknown Object (File)
Jan 28 2024, 9:01 PM
Unknown Object (File)
Jan 28 2024, 2:34 AM
Unknown Object (File)
Jan 23 2024, 7:40 PM
Unknown Object (File)
Jan 23 2024, 7:40 PM
Unknown Object (File)
Jan 23 2024, 7:40 PM
Subscribers

Details

Summary

Ref T9360.

  • View Live useless on archived blogs
  • Edit Blog Image treatment like profiles
  • Pager next/prev should keep you on whatever view you're on
  • Unset user titles aren't falling back properly
  • Add captions to edit fields for better clarification
Test Plan

Archive a blog, Edit a photo, verify pager on live and internal blogs, check empty titles, and view new edit form instructions.

Diff Detail

Repository
rP Phabricator
Branch
phame-2 (branched from master)
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 12836
Build 16355: Run Core Tests
Build 16354: arc lint + arc unit

Event Timeline

chad retitled this revision from to Misc Phame cleanup.
chad updated this object.
chad edited the test plan for this revision. (Show Details)
chad added a reviewer: epriestley.
chad added a task: T9360: Unbeta Phame.
epriestley edited edge metadata.
This revision is now accepted and ready to land.Jun 30 2016, 1:52 AM
This revision was automatically updated to reflect the committed changes.