Page MenuHomePhabricator
Differential D16182

Better destruction of PhameBlog, BadgesBadge
ClosedPublic
Actions

Authored by chad on Jun 28 2016, 12:08 AM.
Tags
None
Referenced Files
F18944905: D16182.diff
Tue, Nov 11, 5:16 PM
F18856484: D16182.id.diff
Sat, Nov 1, 9:59 AM
F18854662: D16182.diff
Sat, Nov 1, 12:25 AM
F18715590: D16182.id.diff
Sep 29 2025, 10:29 AM
F18709713: D16182.diff
Sep 29 2025, 12:33 AM
F18462263: D16182.diff
Sep 1 2025, 9:54 PM
F18344833: D16182.id.diff
Aug 26 2025, 10:15 AM
F18109030: D16182.id38930.diff
Aug 11 2025, 11:22 AM
View All Files
Subscribers
Korvin

Details

Reviewers
epriestley
Commits
rP92fc628b042a: Better destruction of PhameBlog, BadgesBadge
Summary

Allows proper destruction of Badge Awards and Phame Posts.

Test Plan

bin/remove destroy PHID...

Diff Detail

Repository
rP Phabricator
Branch
phame-1 (branched from master)
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 12809
Build 16315: Run Core Tests
Build 16314: arc lint + arc unit

Event Timeline

chad updated this revision to Diff 38930.Jun 28 2016, 12:08 AM
chad retitled this revision from to Better destruction of PhameBlog, BadgesBadge.
chad updated this object.
chad edited the test plan for this revision. (Show Details)
chad added a reviewer: epriestley.
Herald added a subscriber: Korvin. · View Herald TranscriptJun 28 2016, 12:08 AM
epriestley accepted this revision.Jun 28 2016, 12:38 AM
epriestley edited edge metadata.
This revision is now accepted and ready to land.Jun 28 2016, 12:38 AM
chad added a comment.Jun 28 2016, 1:10 AM

Image.png (1×750 px, 105 KB)

Closed by commit rP92fc628b042a: Better destruction of PhameBlog, BadgesBadge (authored by chad, committed by chad). · Explain WhyJun 28 2016, 1:24 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
applications/
badges/
storage/
2 lines
phame/
storage/
8 lines
4 lines

Diff 38930

View Options

src/applications/badges/storage/PhabricatorBadgesBadge.php

Loading...
View Options

src/applications/phame/storage/PhameBlog.php

Loading...
View Options

src/applications/phame/storage/PhamePost.php

Loading...
Phabricator · Built by Phacility