Page MenuHomePhabricator

Censor credentials with "********" instead of "xxxxx"
ClosedPublic

Authored by epriestley on Jun 27 2016, 2:55 PM.
Tags
None
Referenced Files
F13216352: D16181.id.diff
Sat, May 18, 12:17 AM
F13204120: D16181.diff
Wed, May 15, 12:21 AM
F13186904: D16181.diff
Sat, May 11, 4:12 AM
Unknown Object (File)
Tue, May 7, 7:16 AM
Unknown Object (File)
Sat, May 4, 1:19 AM
Unknown Object (File)
Fri, May 3, 5:43 AM
Unknown Object (File)
Thu, Apr 25, 12:56 AM
Unknown Object (File)
Mon, Apr 22, 1:36 AM
Subscribers
None

Details

Summary

Ref T10982. There, and in other cases, it isn't obvious to users that we're censoring credentials when they see censored commands. Try using "****" instead of "xxxxx" to hopefully make it more clear.

Test Plan
  • Ran unit tests.
  • Ran repository pull --trace, saw this output:
>>> [20] <exec> $ git clone --bare -- '********' '/Users/epriestley/dev/core/repo/local/55'
<<< [20] <exec> 3,998,331 us

Diff Detail

Repository
rPHU libphutil
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley retitled this revision from to Censor credentials with "********" instead of "xxxxx".
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
chad edited edge metadata.
This revision is now accepted and ready to land.Jun 27 2016, 3:16 PM
This revision was automatically updated to reflect the committed changes.