Page MenuHomePhabricator

Censor credentials with "********" instead of "xxxxx"
ClosedPublic

Authored by epriestley on Jun 27 2016, 2:55 PM.
Tags
None
Referenced Files
F14962578: D16181.diff
Sun, Feb 16, 7:02 AM
Unknown Object (File)
Sun, Feb 9, 1:53 AM
Unknown Object (File)
Sun, Feb 9, 1:53 AM
Unknown Object (File)
Sun, Feb 9, 1:53 AM
Unknown Object (File)
Sat, Feb 1, 1:58 AM
Unknown Object (File)
Mon, Jan 27, 7:46 AM
Unknown Object (File)
Mon, Jan 27, 1:29 AM
Unknown Object (File)
Fri, Jan 24, 2:21 PM
Subscribers
None

Details

Summary

Ref T10982. There, and in other cases, it isn't obvious to users that we're censoring credentials when they see censored commands. Try using "****" instead of "xxxxx" to hopefully make it more clear.

Test Plan
  • Ran unit tests.
  • Ran repository pull --trace, saw this output:
>>> [20] <exec> $ git clone --bare -- '********' '/Users/epriestley/dev/core/repo/local/55'
<<< [20] <exec> 3,998,331 us

Diff Detail

Repository
rPHU libphutil
Branch
maskstar
Lint
Lint Errors
SeverityLocationCodeMessage
Errorsrc/utils/utils.php:1294XHP45PHP Compatibility
Errorsrc/utils/utils.php:1294XHP45PHP Compatibility
Unit
Tests Passed
Build Status
Buildable 12806
Build 16311: Run Core Tests
Build 16310: arc lint + arc unit

Event Timeline

epriestley retitled this revision from to Censor credentials with "********" instead of "xxxxx".
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
chad edited edge metadata.
This revision is now accepted and ready to land.Jun 27 2016, 3:16 PM
This revision was automatically updated to reflect the committed changes.