Page MenuHomePhabricator

Censor credentials with "********" instead of "xxxxx"
ClosedPublic

Authored by epriestley on Jun 27 2016, 2:55 PM.
Tags
None
Referenced Files
F14043376: D16181.diff
Tue, Nov 12, 9:49 AM
F14031766: D16181.id38928.diff
Sat, Nov 9, 11:52 AM
F14031182: D16181.id38928.diff
Sat, Nov 9, 9:42 AM
F14030760: D16181.diff
Sat, Nov 9, 6:22 AM
F14026159: D16181.diff
Thu, Nov 7, 11:52 PM
F13999167: D16181.diff
Thu, Oct 24, 1:11 PM
F13991628: D16181.id.diff
Tue, Oct 22, 11:53 AM
F13979124: D16181.id38928.diff
Sat, Oct 19, 2:47 AM
Subscribers
None

Details

Summary

Ref T10982. There, and in other cases, it isn't obvious to users that we're censoring credentials when they see censored commands. Try using "****" instead of "xxxxx" to hopefully make it more clear.

Test Plan
  • Ran unit tests.
  • Ran repository pull --trace, saw this output:
>>> [20] <exec> $ git clone --bare -- '********' '/Users/epriestley/dev/core/repo/local/55'
<<< [20] <exec> 3,998,331 us

Diff Detail

Repository
rPHU libphutil
Branch
maskstar
Lint
Lint Errors
SeverityLocationCodeMessage
Errorsrc/utils/utils.php:1294XHP45PHP Compatibility
Errorsrc/utils/utils.php:1294XHP45PHP Compatibility
Unit
Tests Passed
Build Status
Buildable 12806
Build 16311: Run Core Tests
Build 16310: arc lint + arc unit

Event Timeline

epriestley retitled this revision from to Censor credentials with "********" instead of "xxxxx".
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
chad edited edge metadata.
This revision is now accepted and ready to land.Jun 27 2016, 3:16 PM
This revision was automatically updated to reflect the committed changes.