Page MenuHomePhabricator
Differential D16155

Render browse results with global result style
ClosedPublic
Actions

Authored by epriestley on Jun 20 2016, 9:03 PM.
Tags
None
Referenced Files
F14099755: D16155.id38866.diff
Tue, Nov 26, 12:31 PM
F14096084: D16155.id38865.diff
Tue, Nov 26, 1:29 AM
Unknown Object (File)
Sat, Nov 23, 11:45 AM
Unknown Object (File)
Thu, Nov 21, 12:47 AM
Unknown Object (File)
Wed, Nov 20, 9:34 AM
Unknown Object (File)
Tue, Nov 19, 11:49 AM
Unknown Object (File)
Fri, Nov 15, 3:16 PM
Unknown Object (File)
Sun, Nov 10, 9:10 PM
View All Files
Subscribers
None

Details

Reviewers
chad
Maniphest Tasks
T11034: Provide more information about projects, etc. in tokenizer browse dialog to make distinguishing between similar projects easier
Commits
rP6f275ba1441f: Render browse results with global result style
Summary

Ref T11034. This seems a little more promising. Two problems at the moment:

  • This doesn't actually provide any useful information at all right now.
  • Many object types have no profile images.
Test Plan

Screen Shot 2016-06-20 at 1.56.22 PM.png (446×622 px, 34 KB)

Screen Shot 2016-06-20 at 1.57.29 PM.png (470×637 px, 45 KB)

Diff Detail

Repository
rP Phabricator
Branch
token1b
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 12744
Build 16214: Run Core Tests
Build 16213: arc lint + arc unit

Event Timeline

epriestley updated this revision to Diff 38863.Jun 20 2016, 9:03 PM
epriestley retitled this revision from to Render browse results with global result style.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
epriestley added a task: T11034: Provide more information about projects, etc. in tokenizer browse dialog to make distinguishing between similar projects easier.
Herald edited edge metadata. · View Herald TranscriptJun 20 2016, 9:03 PM
chad edited edge metadata.Jun 20 2016, 9:35 PM

I'm sure I can clean up CSS.

chad accepted this revision.Jun 20 2016, 9:35 PM
chad edited edge metadata.
This revision is now accepted and ready to land.Jun 20 2016, 9:35 PM
epriestley added a comment.Jun 20 2016, 9:36 PM

Yeah, I think this one's the most promising. Let me get it filling in the information properly, at least.

epriestley mentioned this in D16154: Use hovercards in browse dialog.Jun 20 2016, 9:36 PM
epriestley mentioned this in D16153: Add more context to tokenizer browse results for people and projects.
epriestley updated this revision to Diff 38865.Jun 20 2016, 11:32 PM
epriestley edited edge metadata.
  • Handle objects with no profile better.
  • Fetch icon + title for users.
  • Fetch description for projects.
  • Show closed status / attributes.
  • Try to do something fairly reasonable for functions.
epriestley added a comment.Jun 20 2016, 11:48 PM

I probably missed a few and this could use some CSS, but I think it at least moves us in a reasonable direction:

Screen Shot 2016-06-20 at 4.47.10 PM.png (471×647 px, 40 KB)

Closed by commit rP6f275ba1441f: Render browse results with global result style (authored by epriestley, committed by epriestley). · Explain WhyJun 20 2016, 11:49 PM
This revision was automatically updated to reflect the committed changes.
chad added a comment.Jun 21 2016, 12:04 AM

Yeah I might try to swap "Select" with "View" and make the entire row the hit area?

Revision Contents
Changeset List

PathSize
resources/
celerity/
4 lines
src/
applications/
people/
typeahead/
18 lines
search/
typeahead/
12 lines
typeahead/
controller/
50 lines
datasource/
5 lines
10 lines
storage/
8 lines
webroot/
rsrc/
css/
aphront/
7 lines

Diff 38863

View Options

resources/celerity/map.php

Loading...
View Options

src/applications/people/typeahead/PhabricatorPeopleDatasource.php

Loading...
View Options

src/applications/search/typeahead/PhabricatorSearchDatasource.php

Loading...
View Options

src/applications/typeahead/controller/PhabricatorTypeaheadModularDatasourceController.php

Loading...
View Options

src/applications/typeahead/datasource/PhabricatorTypeaheadCompositeDatasource.php

Loading...
View Options

src/applications/typeahead/datasource/PhabricatorTypeaheadDatasource.php

Loading...
View Options

src/applications/typeahead/storage/PhabricatorTypeaheadResult.php

Loading...
View Options

webroot/rsrc/css/aphront/typeahead-browse.css

Loading...
Phabricator · Built by Phacility