Page MenuHomePhabricator

Add more context to tokenizer browse results for people and projects
AbandonedPublic

Authored by epriestley on Jun 20 2016, 8:25 PM.

Details

Summary

Ref T11034. Here's roughly what I'm thinking here? Doesn't seem terrible, maybe?

Test Plan

Screen Shot 2016-06-20 at 1.19.49 PM.png (477×666 px, 41 KB)

Screen Shot 2016-06-20 at 1.19.41 PM.png (492×673 px, 27 KB)

Diff Detail

Repository
rP Phabricator
Branch
token1
Lint
Lint Passed
SeverityLocationCodeMessage
Advicesrc/applications/project/typeahead/PhabricatorProjectDatasource.php:59XHP16TODO Comment
Unit
Tests Passed
Build Status
Buildable 12742
Build 16210: Run Core Tests
Build 16209: arc lint + arc unit

Event Timeline

epriestley retitled this revision from to Add more context to tokenizer browse results for people and projects.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.

I don't think this is terrible, but I don't particularly love it. Maybe a better idea would be putting a "(?)" next to "[Select]" which pops the hovercard?

Technically, the token itself could pop the hovercard, so maybe that's even cleaner.

I think the main hang-up is they look like tags, but don't act like tags. Can we just use the same renderer as we do for Global Search? I think that provides 2 lines of context and a photo and feels decent.