Page MenuHomePhabricator

Handle tag tags properly in discovery
ClosedPublic

Authored by epriestley on Jun 20 2016, 6:08 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Feb 16, 7:00 AM
Unknown Object (File)
Feb 9 2025, 1:51 AM
Unknown Object (File)
Feb 2 2025, 6:58 AM
Unknown Object (File)
Feb 2 2025, 5:58 AM
Unknown Object (File)
Jan 30 2025, 10:43 AM
Unknown Object (File)
Jan 24 2025, 2:11 PM
Unknown Object (File)
Jan 21 2025, 10:31 AM
Unknown Object (File)
Jan 15 2025, 10:35 AM
Subscribers
None

Details

Summary

Fixes T11180. In Git, it's possible to tag a tag (????). When you do, we try to log the tag-object, which automatically resolves to the commit and fails.

Just skip these. If "A" points at "B" which points at "C", it's fine to ignore "A" and "B" since we'll get the same stuff when we process "C".

Test Plan
  • Tagged a tag.
  • Pushed it.
  • Discovered it.
  • Before patch: got exception similar to the one in T11180.
  • After patch: got tag-tag skipped. Also got slightly better error messages.

Diff Detail

Repository
rP Phabricator
Branch
tagtag1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 12733
Build 16195: Run Core Tests
Build 16194: arc lint + arc unit

Event Timeline

epriestley retitled this revision from to Handle tag tags properly in discovery.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
chad edited edge metadata.
This revision is now accepted and ready to land.Jun 20 2016, 6:09 PM
This revision was automatically updated to reflect the committed changes.