Fix external blog images
ClosedPublic
Actions

Authored by chad on Jun 19 2016, 2:59 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Thu, Apr 25, 1:25 AM

	Unknown Object (File)
	Fri, Apr 12, 2:13 AM

	Unknown Object (File)
	Tue, Apr 9, 11:56 PM

	Unknown Object (File)
	Mon, Apr 8, 12:07 AM

	Unknown Object (File)
	Mar 28 2024, 9:50 PM

	Unknown Object (File)
	Mar 10 2024, 3:31 PM

	Unknown Object (File)
	Feb 3 2024, 10:58 AM

	Unknown Object (File)
	Feb 2 2024, 2:17 AM

View All Files

Subscribers

Korvin

Tokens

"Pterodactyl" token, awarded by epriestley.

Details

Reviewers

epriestley

Maniphest Tasks

T9897: Unbeta Feedback on Phame

Commits

rPf763c314e107: Fix external blog images

Summary

Reading the code, this seems correct, but I don't have a local test. Ref T9897

Test Plan

read carefully

Diff Detail

Repository

rP Phabricator

Branch

phame-ext (branched from master)

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 12727
Build 16188: Run Core Tests
Build 16187: arc lint + arc unit

Event Timeline

chad updated this revision to Diff 38847.Jun 19 2016, 2:59 PM

chad retitled this revision from to Fix external blog images.

chad updated this object.

chad edited the test plan for this revision. (Show Details)

chad added a reviewer: epriestley.

Herald added a subscriber: Korvin. · View Herald TranscriptJun 19 2016, 2:59 PM

chad updated this object.Jun 19 2016, 2:59 PM

chad added a task: T9897: Unbeta Feedback on Phame.

Let me see if I have a local repro case, one sec...

Looks good locally. Before:

Screen Shot 2016-06-19 at 8.01.56 AM.png (1×2 px, 468 KB)

After:

Screen Shot 2016-06-19 at 8.02.15 AM.png (1×2 px, 1 MB)

This revision is now accepted and ready to land.Jun 19 2016, 3:02 PM

epriestley awarded a token.Jun 19 2016, 3:02 PM

Closed by commit rPf763c314e107: Fix external blog images (authored by chad, committed by chad). · Explain WhyJun 19 2016, 3:06 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

phame/

site/

PhameBlogSite.php

1 line

Diff 38847

View Options

src/applications/phame/site/PhameBlogSite.php

Fix external blog imagesClosedPublicActions