Page MenuHomePhabricator
Differential D16147

Add new super hero header for Phame Blog
ClosedPublic
Actions

Authored by chad on Jun 18 2016, 3:47 AM.
Tags
None
Referenced Files
F13123015: D16147.diff
Tue, Apr 30, 7:14 AM
Unknown Object (File)
Thu, Apr 25, 1:48 AM
Unknown Object (File)
Wed, Apr 17, 4:36 PM
Unknown Object (File)
Thu, Apr 11, 11:34 PM
Unknown Object (File)
Sat, Apr 6, 2:29 AM
Unknown Object (File)
Mar 10 2024, 11:34 AM
Unknown Object (File)
Feb 16 2024, 11:41 AM
Unknown Object (File)
Feb 14 2024, 12:26 PM
View All Files
Subscribers
Korvin

Details

Reviewers
epriestley
Commits
rP20affe9ce887: Add new super hero header for Phame Blog
Summary

Adds a new header layout for Phame Blog. Subtitles now also.

Test Plan

With Image, With Subtitle, Without Image, Without Subtitle. Mobile, Tablet, Desktop.

pasted_file (1×1 px, 322 KB)

Diff Detail

Repository
rP Phabricator
Branch
phame-subheader (branched from master)
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 12721
Build 16181: Run Core Tests
Build 16180: arc lint + arc unit

Event Timeline

chad updated this revision to Diff 38844.Jun 18 2016, 3:47 AM
chad retitled this revision from to Add new super hero header for Phame Blog.
chad updated this object.
chad edited the test plan for this revision. (Show Details)
chad added a reviewer: epriestley.
Herald added a subscriber: Korvin. · View Herald TranscriptJun 18 2016, 3:47 AM
chad edited the test plan for this revision. (Show Details)Jun 18 2016, 3:48 AM
chad added a comment.Jun 18 2016, 3:54 AM

pasted_file (2×2 px, 1018 KB)

epriestley accepted this revision.Jun 18 2016, 12:32 PM
epriestley edited edge metadata.
epriestley added inline comments.
src/applications/phame/storage/PhameBlog.php
44

This might be a little short, but we could expand it later if we run into issues.

This revision is now accepted and ready to land.Jun 18 2016, 12:32 PM
Closed by commit rP20affe9ce887: Add new super hero header for Phame Blog (authored by chad, committed by chad). · Explain WhyJun 18 2016, 2:21 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
resources/
celerity/
4 lines
sql/
autopatches/
2 lines
src/
applications/
phame/
controller/
blog/
21 lines
editor/
8 lines
7 lines
storage/
2 lines
28 lines
webroot/
rsrc/
css/
application/
phame/
40 lines

Diff 38844

View Options

resources/celerity/map.php

Loading...
View Options

resources/sql/autopatches/20160618.phame.blog.subtitle.sql

Loading...
View Options

src/applications/phame/controller/blog/PhameBlogViewController.php

Loading...
View Options

src/applications/phame/editor/PhameBlogEditEngine.php

Loading...
View Options

src/applications/phame/editor/PhameBlogEditor.php

Loading...
View Options

src/applications/phame/storage/PhameBlog.php

Loading...
View Options

src/applications/phame/storage/PhameBlogTransaction.php

Loading...
View Options

webroot/rsrc/css/application/phame/phame.css

Loading...
Phabricator · Built by Phacility