Page MenuHomePhabricator
Differential D16141

Add basic support for Phame blog headers
ClosedPublic
Actions

Authored by chad on Jun 17 2016, 6:55 PM.
Tags
None
Referenced Files
F14464515: D16141.diff
Fri, Dec 27, 10:24 AM
Unknown Object (File)
Fri, Dec 6, 9:05 AM
Unknown Object (File)
Thu, Dec 5, 11:38 PM
Unknown Object (File)
Nov 26 2024, 5:27 PM
Unknown Object (File)
Nov 26 2024, 5:27 PM
Unknown Object (File)
Nov 26 2024, 5:27 PM
Unknown Object (File)
Nov 26 2024, 5:27 PM
Unknown Object (File)
Nov 26 2024, 5:12 PM
View All Files
Subscribers
Korvin
Tokens
"Doubloon" token, awarded by epriestley.

Details

Reviewers
epriestley
Maniphest Tasks
T10901: Support title art for Phame blogs
Commits
rPe384e945d0cf: Add basic support for Phame blog headers
Summary

Fixes T10901. Allows blogs to have headers. I've built this in a basic way, any file, max-height is 240. Should bleed into top crumbs, so any spacing you want you should add to the file itself. Might have to see how users break this.

Test Plan

Set a blog header, see blog header, remove blog header, see no blog header. Check mobile, tablet, desktop break points.

Diff Detail

Repository
rP Phabricator
Branch
phame-header-ui (branched from master)
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 12708
Build 16160: Run Core Tests
Build 16159: arc lint + arc unit

Event Timeline

chad updated this revision to Diff 38831.Jun 17 2016, 6:55 PM
chad retitled this revision from to Add basic support for Phame blog headers.
chad updated this object.
chad edited the test plan for this revision. (Show Details)
chad added a reviewer: epriestley.
chad added a task: T10901: Support title art for Phame blogs.
Herald added a subscriber: Korvin. · View Herald TranscriptJun 17 2016, 6:55 PM
chad edited the test plan for this revision. (Show Details)Jun 17 2016, 6:56 PM
epriestley accepted this revision.Jun 17 2016, 7:00 PM
epriestley edited edge metadata.

On Desktop I think these could maybe even be a bit bigger without being annoying.

src/applications/phame/controller/blog/PhameBlogViewController.php
160

Viewer unused?

This revision is now accepted and ready to land.Jun 17 2016, 7:00 PM
epriestley awarded a token.Jun 17 2016, 7:00 PM
chad updated this revision to Diff 38832.Jun 17 2016, 7:01 PM
chad edited edge metadata.
  • unused
Closed by commit rPe384e945d0cf: Add basic support for Phame blog headers (authored by chad, committed by chad). · Explain WhyJun 17 2016, 7:07 PM
This revision was automatically updated to reflect the committed changes.
chad added a comment.Jun 17 2016, 7:11 PM

Let's see how 240 feels here. I haven't played with it on my laptop/phone personally yet.

chad added a comment.Jun 17 2016, 7:20 PM

lemme know when you throw them up.

epriestley added a comment.Jun 17 2016, 7:20 PM

Code should be live if you want to do the honors.

chad added a comment.Jun 17 2016, 7:23 PM

pasted_file (197×325 px, 13 KB)

epriestley added a comment.Jun 17 2016, 7:24 PM

Haha, try now/

Revision Contents
Changeset List

PathSize
resources/
celerity/
8 lines
src/
applications/
phame/
controller/
1 line
blog/
24 lines
webroot/
rsrc/
css/
application/
phame/
10 lines
phui/
4 lines

Diff 38831

View Options

resources/celerity/map.php

Loading...
View Options

src/applications/phame/controller/PhameLiveController.php

Loading...
View Options

src/applications/phame/controller/blog/PhameBlogViewController.php

Loading...
View Options

webroot/rsrc/css/application/phame/phame.css

Loading...
View Options

webroot/rsrc/css/phui/phui-document-pro.css

Loading...
Phabricator · Built by Phacility