Page MenuHomePhabricator
Differential D16113

fix Vary Subjects option names
ClosedPublic
Actions

Authored by allixsenos on Jun 14 2016, 5:07 PM.
Tags
None
Referenced Files
F13181807: D16113.id.diff
Thu, May 9, 3:54 PM
F13177420: D16113.diff
Wed, May 8, 7:42 PM
Unknown Object (File)
Sat, May 4, 4:31 PM
Unknown Object (File)
Mon, Apr 29, 11:30 PM
Unknown Object (File)
Mon, Apr 29, 2:52 PM
Unknown Object (File)
Sat, Apr 27, 2:13 PM
Unknown Object (File)
Wed, Apr 24, 10:49 PM
Unknown Object (File)
Sat, Apr 20, 3:24 PM
View All Files
Subscribers
Korvin

Details

Reviewers
epriestley
Group Reviewers
Blessed Reviewers
Maniphest Tasks
T11148: option names for Vary Subjects are copypasta from Re-Prefix option
Commits
rPfc1c633bae85: fix Vary Subjects option names
Summary

The option names for Vary Subjects are copypasta from the Add "Re:" Prefix option. Fix their names to refer to Vary Subjects instead.

Fixes T11148

Test Plan

Verify option names for Vary Subjects refer to Add "Re:" Prefix before apply. Verify they no longer do after apply.

Diff Detail

Repository
rP Phabricator
Branch
fix-vary-subjects-option-names (branched from master)
Lint
Lint Passed
Unit
Tests Skipped
Build Status
Buildable 12647
Build 16066: Run Core Tests
Build 16065: arc lint + arc unit

Event Timeline

allixsenos updated this revision to Diff 38771.Jun 14 2016, 5:07 PM
allixsenos retitled this revision from to fix Vary Subjects option names.
allixsenos updated this object.
allixsenos edited the test plan for this revision. (Show Details)
allixsenos added a reviewer: epriestley.
allixsenos added a task: T11148: option names for Vary Subjects are copypasta from Re-Prefix option.
Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptJun 14 2016, 5:07 PM
Herald added a subscriber: Korvin. · View Herald Transcript
epriestley accepted this revision.Jun 14 2016, 5:08 PM
epriestley edited edge metadata.

Thanks!

This revision is now accepted and ready to land.Jun 14 2016, 5:08 PM
Closed by commit rPfc1c633bae85: fix Vary Subjects option names (authored by allixsenos, committed by allixsenos). · Explain WhyJun 14 2016, 5:13 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
applications/
settings/
setting/
4 lines

Diff 38771

View Options

src/applications/settings/setting/PhabricatorEmailVarySubjectsSetting.php

Loading...
Phabricator · Built by Phacility