Page MenuHomePhabricator
Differential D16103

Don't detect long sentences which happen to have a colon in them as Git URIs
ClosedPublic
Actions

Authored by epriestley on Jun 13 2016, 4:33 PM.
Tags
None
Referenced Files
F18906599: D16103.diff
Nov 8 2025, 7:16 PM
F18845022: D16103.id.diff
Oct 29 2025, 9:10 AM
F18764274: D16103.id.diff
Oct 7 2025, 5:14 AM
F18761488: D16103.diff
Oct 6 2025, 2:45 PM
F18629408: D16103.id38750.diff
Sep 16 2025, 8:42 AM
F18617802: D16103.diff
Sep 14 2025, 10:13 PM
F18599991: D16103.diff
Sep 13 2025, 8:45 AM
F18526401: D16103.id.diff
Sep 6 2025, 5:03 PM
View All Files
Subscribers
20after4

Details

Reviewers
chad
Maniphest Tasks
T11137: Unable to update Git repositories with latest stable
Commits
rPHU0dca72380253: (stable) Don't detect long sentences which happen to have a colon in them as…
rPHUa815d2d850b8: Don't detect long sentences which happen to have a colon in them as Git URIs
Summary

Some very liberal code is currently trying to parse commit summaries aggressively as Git URIs, and leading to this:

Failed to parse URI "Summary: Ref T11137. This addresses three general issues:" as a Git URI.

Currently visible here:

https://secure.phabricator.com/rPHU8bb124c37de3dfa29fcd23d4be53a5696b705c81

Don't detect these as Git URIs.

Test Plan

Unit tests.

Diff Detail

Repository
rPHU libphutil
Branch
uri3
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 12619
Build 16022: Run Core Tests
Build 16021: arc lint + arc unit

Event Timeline

epriestley updated this revision to Diff 38742.Jun 13 2016, 4:33 PM
epriestley retitled this revision from to Don't detect long sentences which happen to have a colon in them as Git URIs.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
epriestley added a task: T11137: Unable to update Git repositories with latest stable.
epriestley added a subscriber: 20after4.
chad accepted this revision.Jun 13 2016, 5:10 PM
chad edited edge metadata.
This revision is now accepted and ready to land.Jun 13 2016, 5:10 PM
Closed by commit rPHUa815d2d850b8: Don't detect long sentences which happen to have a colon in them as Git URIs (authored by epriestley, committed by epriestley). · Explain WhyJun 13 2016, 5:25 PM
Closed by commit rPHUa815d2d850b8: Don't detect long sentences which happen to have a colon in them as Git URIs (authored by epriestley, committed by epriestley). · Explain Why
This revision was automatically updated to reflect the committed changes.
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
parser/
8 lines
__tests__/
4 lines

Diff 38742

View Options

src/parser/PhutilURI.php

Loading...
View Options

src/parser/__tests__/PhutilURITestCase.php

Loading...
Phabricator · Built by Phacility