Page MenuHomePhabricator
Differential D16091

Use an HTTPEngineExtension to implement "https.blindly-trust-domains" in Arcanist
ClosedPublic
Actions

Authored by epriestley on Jun 9 2016, 6:47 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Feb 9, 1:47 AM
Unknown Object (File)
Sun, Feb 9, 1:47 AM
Unknown Object (File)
Sun, Feb 9, 1:46 AM
Unknown Object (File)
Mon, Feb 3, 12:24 AM
Unknown Object (File)
Jan 23 2025, 4:00 PM
Unknown Object (File)
Jan 23 2025, 4:00 PM
Unknown Object (File)
Jan 23 2025, 3:59 PM
Unknown Object (File)
Jan 21 2025, 2:44 AM
View All Files
Subscribers
None

Details

Reviewers
chad
Maniphest Tasks
T10227: Provide an extension point for HTTP behaviors (proxies, SSL trust)
Commits
rARC7b0aac5c6f31: (stable) Promote 2016 Week 24
rARC9c412dabf633: (stable) Promote 2016 Week 23
rARCc13e5a629535: Use an HTTPEngineExtension to implement "https.blindly-trust-domains" in…
Summary

Ref T10227. This converts weird hard-codey magic to the new HTTPEngineExtension.

Test Plan

See D16090.

Diff Detail

Repository
rARC Arcanist
Branch
http2
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 12584
Build 15971: Run Core Tests
Build 15970: arc lint + arc unit

Event Timeline

epriestley updated this revision to Diff 38713.Jun 9 2016, 6:47 PM
epriestley retitled this revision from to Use an HTTPEngineExtension to implement "https.blindly-trust-domains" in Arcanist.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
epriestley added a task: T10227: Provide an extension point for HTTP behaviors (proxies, SSL trust).
epriestley added a comment.Jun 9 2016, 6:51 PM

Those build failures are for stuff introduced in D16090.

chad accepted this revision.Jun 9 2016, 6:52 PM
chad edited edge metadata.
This revision is now accepted and ready to land.Jun 9 2016, 6:52 PM
epriestley added a comment.Jun 9 2016, 7:02 PM

(I restarted the build on top of D16090 and it's clean now.)

Closed by commit rARCc13e5a629535: Use an HTTPEngineExtension to implement "https.blindly-trust-domains" in… (authored by epriestley, committed by epriestley). · Explain WhyJun 9 2016, 7:02 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
scripts/
4 lines
src/
2 lines
configuration/
27 lines

Diff 38713

View Options

scripts/arcanist.php

Loading...
View Options

src/__phutil_library_map__.php

Loading...
View Options

src/configuration/ArcanistBlindlyTrustHTTPEngineExtension.php

Loading...
Phabricator · Built by Phacility