Differential D16087

Don't include other users' unpublished drafts when counting Pholio inlines
ClosedPublic
Actions

Authored by epriestley on Jun 9 2016, 3:19 PM.

Details

Reviewers

chad

Maniphest Tasks

T10886: Unpublished, unauthored inline comments in Pholio are incorrectly counted on the image badge

Commits

rP3b1c6073a593: Don't include other users' unpublished drafts when counting Pholio inlines

Summary

Fixes T10886. This should get more formal some day, but just fix it for now.

Test Plan

Reloaded mock with other unpublished draft inlines, saw accurate count.

Diff Detail

Repository

rP Phabricator

Branch

pholio1

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 12577
Build 15960: Run Core Tests
Build 15959: arc lint + arc unit

Event Timeline

epriestley updated this revision to Diff 38706.Jun 9 2016, 3:19 PM

epriestley retitled this revision from to Don't include other users' unpublished drafts when counting Pholio inlines.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: chad.

epriestley added a task: T10886: Unpublished, unauthored inline comments in Pholio are incorrectly counted on the image badge.

eww

This revision is now accepted and ready to land.Jun 9 2016, 3:25 PM

2012 was an uncivilized time

Closed by commit rP3b1c6073a593: Don't include other users' unpublished drafts when counting Pholio inlines (authored by epriestley, committed by epriestley). · Explain WhyJun 9 2016, 3:43 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

pholio/

query/

PholioImageQuery.php

9 lines

Diff 38706

View Options

src/applications/pholio/query/PholioImageQuery.php

Don't include other users' unpublished drafts when counting Pholio inlinesClosedPublicActions