Page MenuHomePhabricator

Give ConpherenceThreadQuery a primary table alias
ClosedPublic

Authored by epriestley on Jun 8 2016, 2:37 PM.
Tags
None
Referenced Files
F13278582: D16080.id38690.diff
Fri, May 31, 11:21 PM
F13268572: D16080.diff
Wed, May 29, 5:11 AM
F13256749: D16080.diff
Sat, May 25, 4:49 PM
F13233163: D16080.diff
Tue, May 21, 1:45 AM
F13213630: D16080.diff
Fri, May 17, 7:57 AM
Unknown Object (File)
Tue, May 7, 7:39 AM
Unknown Object (File)
Mon, May 6, 3:40 AM
Unknown Object (File)
Fri, May 3, 7:15 AM
Subscribers
None

Details

Summary

Fixes T11113. On the 2nd+ page, we could end up with an ambiguous id WHERE clause because we don't define a primary table alias on this query. Define one.

Test Plan

Changed SearchEngine to return pages of size 5, searched for my threads, toggled to second page, no exception.

Used DarkConsole to examine that second-page query, saw that it had thread.id explicitly instead of id implicitly.

Diff Detail

Repository
rP Phabricator
Branch
conq1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 12562
Build 15940: Run Core Tests
Build 15939: arc lint + arc unit

Event Timeline

epriestley retitled this revision from to Give ConpherenceThreadQuery a primary table alias.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
chad edited edge metadata.
This revision is now accepted and ready to land.Jun 8 2016, 2:37 PM
This revision was automatically updated to reflect the committed changes.