Ref T3353. Currently, if text ends in newlines (or some other types of punctuation) we generate an extra piece at the end which can muck up the algorithm.
Do a slightly better job with this.
Details
Details
- Reviewers
chad - Maniphest Tasks
- T3353: Make Phriction Document changes reviewable
- Commits
- rPHU557309b9242a: Slightly improve prose diffs for text ending in newlines or punctuation
Viewed a diff between "a\nb\nc\n" and "a\nb\nc\nd\n", got a cleaner diff out of it.
Diff Detail
Diff Detail
- Repository
- rPHU libphutil
- Branch
- prose3
- Lint
Lint Passed - Unit
Tests Passed - Build Status
Buildable 12516 Build 15872: Run Core Tests Build 15871: arc lint + arc unit