Page MenuHomePhabricator
Differential D16056

Render sometimes-legible prose diffs in the Phabricator UI
ClosedPublic
Actions

Authored by epriestley on Jun 6 2016, 3:23 PM.
Tags
None
Referenced Files
F13169208: D16056.diff
Tue, May 7, 8:15 AM
Unknown Object (File)
Fri, May 3, 7:58 AM
Unknown Object (File)
Wed, May 1, 6:50 AM
Unknown Object (File)
Thu, Apr 25, 1:57 AM
Unknown Object (File)
Wed, Apr 24, 7:26 AM
Unknown Object (File)
Tue, Apr 23, 7:31 AM
Unknown Object (File)
Fri, Apr 19, 4:50 PM
Unknown Object (File)
Fri, Apr 19, 4:40 PM
View All Files
Subscribers
None

Details

Reviewers
chad
Maniphest Tasks
T3353: Make Phriction Document changes reviewable
Commits
rPb3477bfc5637: Render sometimes-legible prose diffs in the Phabricator UI
Summary

Ref T3353. This hooks the prose engine up to the UI and throws away the hard-wrapping hacks.

These are likely still very rough in many cases, but are hopefully a big step forward from the old version in the vast majority of cases.

Test Plan

Screen Shot 2016-06-06 at 8.16.19 AM.png (1×1 px, 251 KB)

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley updated this revision to Diff 38632.Jun 6 2016, 3:23 PM
epriestley retitled this revision from to Render sometimes-legible prose diffs in the Phabricator UI.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
epriestley added a task: T3353: Make Phriction Document changes reviewable.
Herald edited edge metadata. · View Herald TranscriptJun 6 2016, 3:23 PM
chad accepted this revision.Jun 6 2016, 7:26 PM
chad edited edge metadata.
This revision is now accepted and ready to land.Jun 6 2016, 7:26 PM
Closed by commit rPb3477bfc5637: Render sometimes-legible prose diffs in the Phabricator UI (authored by epriestley, committed by epriestley). · Explain WhyJun 6 2016, 7:33 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
resources/
celerity/
12 lines
src/
applications/
transactions/
controller/
3 lines
view/
67 lines
webroot/
rsrc/
css/
application/
differential/
19 lines

Diff 38637

View Options

resources/celerity/map.php

Loading...
View Options

src/applications/transactions/controller/PhabricatorApplicationTransactionDetailController.php

Loading...
View Options

src/applications/transactions/view/PhabricatorApplicationTransactionTextDiffDetailView.php

Loading...
View Options

webroot/rsrc/css/application/differential/changeset-view.css

Loading...
Phabricator · Built by Phacility