Page MenuHomePhabricator

Render sometimes-legible prose diffs in the Phabricator UI
ClosedPublic

Authored by epriestley on Jun 6 2016, 3:23 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Sep 7, 7:07 AM
Unknown Object (File)
Sun, Sep 6, 6:32 AM
Unknown Object (File)
Tue, Aug 25, 7:43 AM
Unknown Object (File)
Jun 25 2026, 3:32 PM
Unknown Object (File)
Jun 24 2026, 10:37 PM
Unknown Object (File)
Jun 22 2026, 11:30 PM
Unknown Object (File)
Jun 22 2026, 3:15 AM
Unknown Object (File)
Jun 21 2026, 7:36 PM
Subscribers
None

Details

Summary

Ref T3353. This hooks the prose engine up to the UI and throws away the hard-wrapping hacks.

These are likely still very rough in many cases, but are hopefully a big step forward from the old version in the vast majority of cases.

Test Plan

Screen Shot 2016-06-06 at 8.16.19 AM.png (1×1 px, 251 KB)

Diff Detail

Repository
rP Phabricator
Branch
prose2
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 12503
Build 15851: Run Core Tests
Build 15850: arc lint + arc unit

Event Timeline

epriestley retitled this revision from to Render sometimes-legible prose diffs in the Phabricator UI.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
chad edited edge metadata.
This revision is now accepted and ready to land.Jun 6 2016, 7:26 PM
This revision was automatically updated to reflect the committed changes.