Page MenuHomePhabricator

Very rough cut of prose diffs
ClosedPublic

Authored by epriestley on Jun 6 2016, 3:01 PM.
Tags
None
Referenced Files
F12837982: D16055.id38630.diff
Thu, Mar 28, 5:43 PM
F12837951: D16055.id38630.diff
Thu, Mar 28, 5:41 PM
F12834426: D16055.id.diff
Thu, Mar 28, 2:37 PM
F12834349: D16055.id.diff
Thu, Mar 28, 2:35 PM
Unknown Object (File)
Mon, Mar 25, 3:28 PM
Unknown Object (File)
Thu, Mar 21, 9:10 AM
Unknown Object (File)
Mon, Mar 11, 7:03 AM
Unknown Object (File)
Feb 3 2024, 10:35 AM
Subscribers
None

Details

Summary

Ref T3353. This is just sketching things out so I can wire them up. It probably doesn't do a particularly good job, but we can start refining it once it's hooked up the UI and we can catch problem cases.

Test Plan

Ran prosediff.php, got reasonable looking results for a simple test case:

Screen Shot 2016-06-06 at 7.59.37 AM.png (308×1 px, 126 KB)

Diff Detail

Repository
rPHU libphutil
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley retitled this revision from to Very rough cut of prose diffs.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
  • Also combine runs of "++++", etc.
chad edited edge metadata.
This revision is now accepted and ready to land.Jun 6 2016, 7:10 PM
This revision was automatically updated to reflect the committed changes.