Page MenuHomePhabricator

Very rough cut of prose diffs
ClosedPublic

Authored by epriestley on Jun 6 2016, 3:01 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Nov 21, 9:38 PM
Unknown Object (File)
Thu, Nov 21, 9:20 PM
Unknown Object (File)
Thu, Nov 21, 12:24 PM
Unknown Object (File)
Sun, Nov 17, 7:58 PM
Unknown Object (File)
Sat, Nov 16, 6:34 PM
Unknown Object (File)
Thu, Nov 14, 12:14 PM
Unknown Object (File)
Sun, Nov 10, 2:28 AM
Unknown Object (File)
Sat, Nov 9, 2:03 PM
Subscribers
None

Details

Summary

Ref T3353. This is just sketching things out so I can wire them up. It probably doesn't do a particularly good job, but we can start refining it once it's hooked up the UI and we can catch problem cases.

Test Plan

Ran prosediff.php, got reasonable looking results for a simple test case:

Screen Shot 2016-06-06 at 7.59.37 AM.png (308×1 px, 126 KB)

Diff Detail

Repository
rPHU libphutil
Branch
prose1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 12502
Build 15849: Run Core Tests
Build 15848: arc lint + arc unit

Event Timeline

epriestley retitled this revision from to Very rough cut of prose diffs.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
  • Also combine runs of "++++", etc.
chad edited edge metadata.
This revision is now accepted and ready to land.Jun 6 2016, 7:10 PM
This revision was automatically updated to reflect the committed changes.