Page MenuHomePhabricator

Render sometimes-legible prose diffs in the Phabricator UI
ClosedPublic

Authored by epriestley on Jun 6 2016, 3:23 PM.
Tags
None
Referenced Files
F18851738: D16056.id.diff
Fri, Oct 31, 3:39 AM
F18847232: D16056.diff
Wed, Oct 29, 11:32 PM
F18812876: D16056.id38637.diff
Oct 20 2025, 12:50 PM
F18802181: D16056.id38632.diff
Oct 17 2025, 6:37 PM
F18783245: D16056.id38637.diff
Oct 13 2025, 5:22 AM
F18776758: D16056.id.diff
Oct 10 2025, 11:20 PM
F18740993: D16056.id.diff
Oct 2 2025, 7:21 AM
F18738161: D16056.id38637.diff
Oct 1 2025, 2:22 PM
Subscribers
None

Details

Summary

Ref T3353. This hooks the prose engine up to the UI and throws away the hard-wrapping hacks.

These are likely still very rough in many cases, but are hopefully a big step forward from the old version in the vast majority of cases.

Test Plan

Screen Shot 2016-06-06 at 8.16.19 AM.png (1×1 px, 251 KB)

Diff Detail

Repository
rP Phabricator
Branch
prose2
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 12503
Build 15851: Run Core Tests
Build 15850: arc lint + arc unit

Event Timeline

epriestley retitled this revision from to Render sometimes-legible prose diffs in the Phabricator UI.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
chad edited edge metadata.
This revision is now accepted and ready to land.Jun 6 2016, 7:26 PM
This revision was automatically updated to reflect the committed changes.