Page MenuHomePhabricator

Render sometimes-legible prose diffs in the Phabricator UI
ClosedPublic

Authored by epriestley on Jun 6 2016, 3:23 PM.
Tags
None
Referenced Files
F15434630: D16056.id.diff
Tue, Mar 25, 4:44 AM
F15434135: D16056.id38632.diff
Tue, Mar 25, 2:09 AM
F15429214: D16056.diff
Mon, Mar 24, 1:11 AM
F15423600: D16056.diff
Sat, Mar 22, 4:13 PM
F15383000: D16056.diff
Fri, Mar 14, 3:12 PM
F15310878: D16056.diff
Mar 6 2025, 9:32 AM
Unknown Object (File)
Mar 3 2025, 4:38 PM
Unknown Object (File)
Feb 25 2025, 10:01 AM
Subscribers
None

Details

Summary

Ref T3353. This hooks the prose engine up to the UI and throws away the hard-wrapping hacks.

These are likely still very rough in many cases, but are hopefully a big step forward from the old version in the vast majority of cases.

Test Plan

Screen Shot 2016-06-06 at 8.16.19 AM.png (1×1 px, 251 KB)

Diff Detail

Repository
rP Phabricator
Branch
prose2
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 12503
Build 15851: Run Core Tests
Build 15850: arc lint + arc unit

Event Timeline

epriestley retitled this revision from to Render sometimes-legible prose diffs in the Phabricator UI.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
chad edited edge metadata.
This revision is now accepted and ready to land.Jun 6 2016, 7:26 PM
This revision was automatically updated to reflect the committed changes.