Page MenuHomePhabricator
Differential D16036

Allow users to turn off desktop notifications
ClosedPublic
Actions

Authored by epriestley on Jun 4 2016, 10:02 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Dec 19, 12:45 PM
Unknown Object (File)
Sat, Dec 14, 9:34 PM
Unknown Object (File)
Thu, Dec 12, 10:53 PM
Unknown Object (File)
Thu, Dec 12, 3:18 PM
Unknown Object (File)
Sat, Dec 7, 10:46 PM
Unknown Object (File)
Sat, Nov 30, 1:21 PM
Unknown Object (File)
Wed, Nov 27, 8:49 PM
Unknown Object (File)
Wed, Nov 27, 12:24 PM
View All Files
Subscribers
None

Details

Reviewers
chad
Maniphest Tasks
T4103: Implement "Role Profiles" to provide search, homepage and application defaults
T8846: Unable to turn off Desktop Notifications
Commits
rP9d7c28625240: Allow users to turn off desktop notifications
Summary

Fixes T8846. Ref T4103. I just took the shortest reasonable path here, this panel could use some attention on the next Conpherence iteration.

Test Plan

Turned on/off desktop notifications. Observed corresponding behavior in test notifications.

Diff Detail

Repository
rP Phabricator
Branch
setting25
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 12457
Build 15780: Run Core Tests
Build 15779: arc lint + arc unit

Event Timeline

epriestley updated this revision to Diff 38586.Jun 4 2016, 10:02 PM
epriestley retitled this revision from to Allow users to turn off desktop notifications.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
epriestley added tasks: T8846: Unable to turn off Desktop Notifications, T4103: Implement "Role Profiles" to provide search, homepage and application defaults.
chad accepted this revision.Jun 4 2016, 10:13 PM
chad edited edge metadata.
This revision is now accepted and ready to land.Jun 4 2016, 10:13 PM
Closed by commit rP9d7c28625240: Allow users to turn off desktop notifications (authored by epriestley, committed by epriestley). · Explain WhyJun 5 2016, 3:49 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 38586

View Options

src/__phutil_library_map__.php

Loading...
View Options

src/applications/notification/builder/PhabricatorNotificationBuilder.php

Loading...
View Options

src/applications/notification/controller/PhabricatorNotificationIndividualController.php

Loading...
View Options

src/applications/notification/controller/PhabricatorNotificationPanelController.php

Loading...
View Options

src/applications/settings/panel/PhabricatorDesktopNotificationsSettingsPanel.php

Loading...
View Options

src/applications/settings/panel/PhabricatorHomePreferencesSettingsPanel.php

Loading...
View Options

src/applications/settings/panel/PhabricatorSettingsPanel.php

Loading...
View Options

src/applications/settings/setting/PhabricatorDesktopNotificationsSetting.php

Loading...
View Options

src/applications/settings/storage/PhabricatorUserPreferences.php

Loading...
Phabricator · Built by Phacility