Page MenuHomePhabricator
Differential D16034

Modernize various menu collapse settings
ClosedPublic
Actions

Authored by epriestley on Jun 4 2016, 3:09 PM.
Tags
None
Referenced Files
F13268440: D16034.diff
Wed, May 29, 5:02 AM
F13256280: D16034.diff
Sat, May 25, 10:52 AM
F13244906: D16034.id.diff
Thu, May 23, 5:25 AM
F13231173: D16034.diff
Tue, May 21, 12:14 AM
F13185292: D16034.diff
Sat, May 11, 2:46 AM
F13174750: D16034.id.diff
Wed, May 8, 1:00 AM
Unknown Object (File)
Tue, May 7, 5:11 AM
Unknown Object (File)
May 3 2024, 2:31 AM
View All Files
Subscribers
None

Details

Reviewers
chad
Maniphest Tasks
T4103: Implement "Role Profiles" to provide search, homepage and application defaults
Commits
rPfc45de29a6fa: Modernize various menu collapse settings
Summary

Ref T4103. Fully modernize the filetree show/hide, durable column show/hide, and profile menu collapse/wide settings.

Test Plan
  • Toggled filetree on/off, reloaded page, setting stuck.
  • Same with conpherence column and profile menus.

Diff Detail

Repository
rP Phabricator
Branch
setting21
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 12438
Build 15759: Run Core Tests
Build 15758: arc lint + arc unit

Event Timeline

epriestley updated this revision to Diff 38567.Jun 4 2016, 3:09 PM
epriestley retitled this revision from to Modernize various menu collapse settings.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
epriestley added a task: T4103: Implement "Role Profiles" to provide search, homepage and application defaults.
chad accepted this revision.Jun 4 2016, 6:22 PM
chad edited edge metadata.
This revision is now accepted and ready to land.Jun 4 2016, 6:22 PM
Closed by commit rPfc45de29a6fa: Modernize various menu collapse settings (authored by epriestley, committed by epriestley). · Explain WhyJun 4 2016, 9:44 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 38567

View Options

src/__phutil_library_map__.php

Loading...
View Options

src/applications/conpherence/view/ConpherenceDurableColumnView.php

Loading...
View Options

src/applications/differential/controller/DifferentialRevisionViewController.php

Loading...
View Options

src/applications/diffusion/controller/DiffusionCommitController.php

Loading...
View Options

src/applications/search/engine/PhabricatorProfilePanelEngine.php

Loading...
View Options

src/applications/settings/setting/PhabricatorConpherenceColumnVisibleSetting.php

Loading...
View Options

src/applications/settings/setting/PhabricatorFiletreeVisibleSetting.php

Loading...
View Options

src/applications/settings/setting/PhabricatorProfileMenuCollapsedSetting.php

Loading...
View Options

src/applications/settings/storage/PhabricatorUserPreferences.php

Loading...
View Options

src/view/page/PhabricatorStandardPageView.php

Loading...
Phabricator · Built by Phacility