Turn DarkConsole settings into real settings
ClosedPublic
Actions

Authored by epriestley on Jun 3 2016, 5:53 PM.

Details

Reviewers

chad

Maniphest Tasks

T4103: Implement "Role Profiles" to provide search, homepage and application defaults

Commits

rP109917a94b39: Turn DarkConsole settings into real settings

Summary

Ref T4103. These settings long-predate proper settings and are based on hard-coded user properties. Turn them into real settings.

(I didn't try to migrate the value since they're trivial to restore and only useful to developers.)

Test Plan

Toggled console on/off.
Swapped tabs.
Reloaded page, everything stayed sticky.

Diff Detail

Repository

rP Phabricator

Branch

setting19

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 12429
Build 15745: Run Core Tests
Build 15744: arc lint + arc unit

Event Timeline

epriestley updated this revision to Diff 38560.Jun 3 2016, 5:53 PM

epriestley retitled this revision from to Turn DarkConsole settings into real settings.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: chad.

epriestley added a task: T4103: Implement "Role Profiles" to provide search, homepage and application defaults.

chad accepted this revision.Jun 3 2016, 5:54 PM

chad edited edge metadata.

This revision is now accepted and ready to land.Jun 3 2016, 5:54 PM

I wonder if this could replace darkconsole.always-on since one could turn it on for the 'logged out' or 'default' profile? Just a thought.

I expect to be able to be able to get rid of at least a few other settings like metamta.vary-subjects and metamta.re-prefix and just move them to the global profile.

Stuff like darkconsole.always-on and phabricator.timezone might be removable too, but they enable slightly different behavior than a global default would and may have some boostrapping issues (e.g., we might emit a log early on that needs the timezone defined, before we have a chance to build it from storage).