Page MenuHomePhabricator

SVN buildSyntheticAdditionDiff: exit sooner if path is a directory
ClosedPublic

Authored by allanjude on May 29 2016, 10:12 PM.
Referenced Files
Unknown Object (File)
Thu, May 2, 10:02 PM
Unknown Object (File)
Thu, Apr 25, 12:58 AM
Unknown Object (File)
Tue, Apr 16, 3:50 AM
Unknown Object (File)
Fri, Apr 12, 3:28 AM
Unknown Object (File)
Mar 31 2024, 5:17 PM
Unknown Object (File)
Mar 21 2024, 10:23 PM
Unknown Object (File)
Mar 21 2024, 12:09 PM
Unknown Object (File)
Mar 20 2024, 10:53 AM
Subscribers

Details

Summary

When doing svn copy, or svn mv, a SynthenticAdditionDiff is generated.

If the path is a directory, an error will occur when checking the
mime-type of the directory. Immediately after the properties check,
the function returns null if the path is a directory. Move this
check to before the properties check to avoid exiting with an error.

Command failed with error #1!
COMMAND
svn propget 'svn:mime-type' '/home/trasz/svn/ports/cad/py-pycam'@

STDOUT
(empty)

STDERR
svn: warning: W200017: Property 'svn:mime-type' not found on '/home/trasz/svn/ports/cad/py-pycam@'
svn: E200000: A problem occurred; see other errors for details

(Run with `--trace` for a full exception trace.)
Test Plan

Created differentials of changes with svn copy and svn mv

Diff Detail

Repository
rARC Arcanist
Branch
svn_copy_fail_props
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 12355
Build 15630: arc lint + arc unit

Event Timeline

allanjude retitled this revision from to SVN buildSyntheticAdditionDiff: exit sooner if path is a directory.
allanjude updated this object.
allanjude edited the test plan for this revision. (Show Details)
epriestley removed a task: Restricted Maniphest Task.Jun 1 2016, 12:25 PM
This revision is now accepted and ready to land.Jun 5 2016, 10:12 PM
This revision was automatically updated to reflect the committed changes.