Fix weird remarkup linewrapping on a few instructions forms, plus move toward fixing Phame/CORGI remarkup issues
ClosedPublic
Actions

Authored by epriestley on May 22 2016, 4:59 PM.

Details

Reviewers

chad

Maniphest Tasks

T10381: Tweak linebreak preservation behavior of PHUIRemarkupView

Commits

rP3d3fff4991ab: Fix weird remarkup linewrapping on a few instructions forms, plus move toward…

Summary

Fixes T10381. When we converted to PHUIRemarkupView, some instructional text got linebreaks added when it shouldn't have them (the source is written in PHP and wrapped at 80 characters, but the output should flow naturally).

Fix this so we don't preserve linebreaks.

This also makes PHUIRemarkupView a little more powerful and inches us toward fixing Phame/CORGI remarkup issues, getting rid of PhabricatorMarkupInterface / PhabricatorMarkupOneOff, and dropping all the application hard-coding in PhabricatorMarkupEngine.

Test Plan

Grepped for all callsites, looking for callsites which accept remarkup written in <<<HEREDOC format.
Viewed form instructions, Conduit API methods, HTTP parameter edit instructions.

Diff Detail

Repository

rP Phabricator

Branch

linebreak1

Lint

Lint Passed

Severity	Location	Code	Message
Advice	src/infrastructure/markup/view/PHUIRemarkupView.php:18	XHP16	TODO Comment

Unit

Tests Passed

Build Status

Buildable 12307
Build 15560: Run Core Tests
Build 15559: arc lint + arc unit

Event Timeline

epriestley updated this revision to Diff 38432.May 22 2016, 4:59 PM

epriestley retitled this revision from to Fix weird remarkup linewrapping on a few instructions forms, plus move toward fixing Phame/CORGI remarkup issues.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: chad.

epriestley added a task: T10381: Tweak linebreak preservation behavior of PHUIRemarkupView.

epriestley added inline comments.May 22 2016, 4:59 PM