Page MenuHomePhabricator

Abort HM Steps that are waiting for message
Changes PlannedPublic

Authored by avivey on May 20 2016, 8:59 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Feb 1, 4:03 AM
Unknown Object (File)
Wed, Jan 29, 1:02 AM
Unknown Object (File)
Tue, Jan 28, 1:30 AM
Unknown Object (File)
Thu, Jan 23, 3:27 PM
Unknown Object (File)
Thu, Jan 23, 3:27 PM
Unknown Object (File)
Sat, Jan 18, 3:22 AM
Unknown Object (File)
Wed, Jan 15, 7:36 PM
Unknown Object (File)
Mon, Jan 13, 1:58 PM

Details

Summary

Ref T5936. When aborting a job, allow steps that invoke a remote action to cancel the remote action.

Test Plan

Turns out that I don't actually have the other side of this implemented, so I can't test it. I'm just arc-diffing it to keep
the code in context.

Diff Detail

Repository
rP Phabricator
Branch
master
Lint
Lint Passed
SeverityLocationCodeMessage
Advicesrc/applications/harbormaster/engine/HarbormasterBuildEngine.php:319XHP16TODO Comment
Unit
Tests Passed
Build Status
Buildable 12291
Build 15538: Run Core Tests
Build 15537: arc lint + arc unit