Page MenuHomePhabricator

Use new Differential bucketing logic on default (non-dashboard) homepage
ClosedPublic

Authored by epriestley on May 19 2016, 8:32 PM.
Tags
None
Referenced Files
F13161705: D15950.id38404.diff
Mon, May 6, 9:20 AM
Unknown Object (File)
Sat, May 4, 7:43 PM
Unknown Object (File)
Fri, May 3, 9:30 AM
Unknown Object (File)
Wed, May 1, 8:25 AM
Unknown Object (File)
Fri, Apr 26, 11:22 AM
Unknown Object (File)
Thu, Apr 25, 3:09 AM
Unknown Object (File)
Wed, Apr 24, 3:44 AM
Unknown Object (File)
Wed, Apr 24, 3:44 AM
Subscribers
None

Details

Summary

Ref T10939. If you haven't installed a dashboard, we show an "Active Revisions" panel on the homepage by default. I waited a bit to update this, but the new buckets don't seem to have caused any major problems so far.

Update this to use the new logic. I'm just showing "must review" + "should review", which is similar to the old beahvior.

Also replace the notification count with this same number. This is a little different from the old behavior, but simpler, and I think we should probably move toward getting rid of these counts completely.

Test Plan
  • Viewed homepage as logged-in user, saw my revisions (including revisions I have authority over only because of project membership).
  • Saw consistent notification count.
  • Grepped for removed method.

Diff Detail

Repository
rP Phabricator
Branch
diff1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 12274
Build 15513: Run Core Tests
Build 15512: arc lint + arc unit

Event Timeline

epriestley retitled this revision from to Use new Differential bucketing logic on default (non-dashboard) homepage.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
chad edited edge metadata.
This revision is now accepted and ready to land.May 19 2016, 10:07 PM
This revision was automatically updated to reflect the committed changes.