Differential D15929

Put revisions you're a reviewer on which need review and which you've commented on in "Should Review"
ClosedPublic
Actions

Authored by epriestley on May 16 2016, 6:37 PM.

Details

Reviewers

chad

Maniphest Tasks

T10939: Support for OWNERS files

Commits

rPc5853b4f4820: Put revisions you're a reviewer on which need review and which you've…

Summary

Ref T10939. These poor stragglers got left out in the rain. Didn't catch any issues otherwise.

Test Plan

Diff Detail

Repository

rP Phabricator

Branch

dash8

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 12229
Build 15446: Run Core Tests
Build 15445: arc lint + arc unit

Event Timeline

epriestley updated this revision to Diff 38355.May 16 2016, 6:37 PM

epriestley retitled this revision from to Put revisions you're a reviewer on which need review and which you've commented on in "Should Review".

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: chad.

epriestley added a task: T10939: Support for OWNERS files.

chad accepted this revision.May 16 2016, 6:38 PM

chad edited edge metadata.

This revision is now accepted and ready to land.May 16 2016, 6:38 PM

Closed by commit rPc5853b4f4820: Put revisions you're a reviewer on which need review and which you've… (authored by epriestley, committed by epriestley). · Explain WhyMay 16 2016, 6:39 PM

This revision was automatically updated to reflect the committed changes.

epriestley mentioned this in T10939: Support for OWNERS files.May 16 2016, 7:55 PM

epriestley mentioned this in T5238: Treat "Accepted" and "Accepted but Blocked" differentials differently within the UI.May 17 2016, 1:59 PM

Revision Contents
Changeset List

Path

Size

src/

applications/

differential/

query/

DifferentialRevisionRequiredActionResultBucket.php

1 line

Diff 38355

View Options

src/applications/differential/query/DifferentialRevisionRequiredActionResultBucket.php

Put revisions you're a reviewer on which need review and which you've commented on in "Should Review"ClosedPublicActions