Page MenuHomePhabricator
Differential D15909

Consider packages when calculating Differential authority
ClosedPublic
Actions

Authored by epriestley on May 13 2016, 2:31 PM.
Tags
None
Referenced Files
F13179614: D15909.diff
Wed, May 8, 9:19 PM
Unknown Object (File)
Sat, May 4, 6:53 PM
Unknown Object (File)
Sat, May 4, 2:09 PM
Unknown Object (File)
Wed, May 1, 8:13 AM
Unknown Object (File)
Wed, May 1, 12:20 AM
Unknown Object (File)
Tue, Apr 30, 5:24 AM
Unknown Object (File)
Tue, Apr 30, 5:24 AM
Unknown Object (File)
Mon, Apr 29, 5:25 AM
View All Files
Subscribers
None

Details

Reviewers
chad
Maniphest Tasks
T10939: Support for OWNERS files
Commits
rP44057ad26985: Consider packages when calculating Differential authority
Summary

Ref T10939. This has no effect yet since packages can not actually become reviewers, I'm just inching toward support.

  • When searching for "responsible users", include revisions that need review by packages you have authority over.
  • When calculating review authority, include authority over packages you are a member of (these currently never exist).
Test Plan

This isn't reachable so I just var_dump()'d stuff and looked at the generated queries, which appeared correct/reasonable.

I'll vet this more thoroughly once packages can actually become reviewers.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley updated this revision to Diff 38313.May 13 2016, 2:31 PM
epriestley retitled this revision from to Consider packages when calculating Differential authority.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
epriestley added a task: T10939: Support for OWNERS files.
chad accepted this revision.May 13 2016, 2:57 PM
chad edited edge metadata.
This revision is now accepted and ready to land.May 13 2016, 2:57 PM
Closed by commit rP44057ad26985: Consider packages when calculating Differential authority (authored by epriestley, committed by epriestley). · Explain WhyMay 14 2016, 12:17 AM
This revision was automatically updated to reflect the committed changes.
epriestley mentioned this in T10939: Support for OWNERS files.May 14 2016, 1:02 AM
epriestley mentioned this in T5000: Using Differential with plain Git, without requiring Arc.May 20 2016, 11:04 PM

Revision Contents
Changeset List

PathSize
src/
applications/
differential/
query/
54 lines

Diff 38325

View Options

src/applications/differential/query/DifferentialRevisionQuery.php

Loading...
Phabricator · Built by Phacility