Page MenuHomePhabricator

Consider packages when calculating Differential authority
ClosedPublic

Authored by epriestley on May 13 2016, 2:31 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Mar 19, 3:30 AM
Unknown Object (File)
Sat, Mar 16, 8:15 AM
Unknown Object (File)
Sat, Mar 9, 7:55 AM
Unknown Object (File)
Tue, Mar 5, 3:14 PM
Unknown Object (File)
Fri, Mar 1, 1:02 AM
Unknown Object (File)
Feb 21 2024, 7:26 AM
Unknown Object (File)
Feb 20 2024, 10:11 PM
Unknown Object (File)
Feb 15 2024, 10:27 AM
Subscribers
None

Details

Summary

Ref T10939. This has no effect yet since packages can not actually become reviewers, I'm just inching toward support.

  • When searching for "responsible users", include revisions that need review by packages you have authority over.
  • When calculating review authority, include authority over packages you are a member of (these currently never exist).
Test Plan

This isn't reachable so I just var_dump()'d stuff and looked at the generated queries, which appeared correct/reasonable.

I'll vet this more thoroughly once packages can actually become reviewers.

Diff Detail

Repository
rP Phabricator
Branch
owners2
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 12185
Build 15380: Run Core Tests
Build 15379: arc lint + arc unit

Event Timeline

epriestley retitled this revision from to Consider packages when calculating Differential authority.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
chad edited edge metadata.
This revision is now accepted and ready to land.May 13 2016, 2:57 PM
This revision was automatically updated to reflect the committed changes.