Page MenuHomePhabricator
Differential D15912

Make packages mailable and subscribable
ClosedPublic
Actions

Authored by epriestley on May 13 2016, 5:41 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Apr 20, 4:55 AM
Unknown Object (File)
Fri, Apr 19, 4:40 PM
Unknown Object (File)
Mon, Apr 15, 10:08 AM
Unknown Object (File)
Sun, Apr 7, 2:20 PM
Unknown Object (File)
Sat, Apr 6, 10:22 PM
Unknown Object (File)
Tue, Apr 2, 5:58 AM
Unknown Object (File)
Mon, Apr 1, 9:01 PM
Unknown Object (File)
Fri, Mar 29, 10:31 AM
View All Files
Subscribers
None

Details

Reviewers
chad
Maniphest Tasks
T7834: Package owners doesn't get mail after a commit triggers an audit
T10939: Support for OWNERS files
Commits
rP547abfe87391: Make packages mailable and subscribable
Summary

Ref T10939. Fixes T7834.

  • Make packages into mailable objects, like projects and users.
  • Packages resolve recipients by resolving project and user owners into recipients.
Test Plan
  • Added a comment to a revision with a package subscriber.
  • Used bin/mail show-outbound to see that owners got mail.

Diff Detail

Repository
rP Phabricator
Branch
owners5
Lint
Lint Passed
SeverityLocationCodeMessage
Advicesrc/applications/owners/storage/PhabricatorOwnersPackage.php:297XHP16TODO Comment
Unit
Tests Passed
Build Status
Buildable 12188
Build 15386: Run Core Tests
Build 15385: arc lint + arc unit

Event Timeline

epriestley updated this revision to Diff 38316.May 13 2016, 5:41 PM
epriestley retitled this revision from to Make packages mailable and subscribable.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
epriestley added tasks: T10939: Support for OWNERS files, T7834: Package owners doesn't get mail after a commit triggers an audit.
chad accepted this revision.May 13 2016, 7:28 PM
chad edited edge metadata.
This revision is now accepted and ready to land.May 13 2016, 7:28 PM
Closed by commit rP547abfe87391: Make packages mailable and subscribable (authored by epriestley, committed by epriestley). · Explain WhyMay 14 2016, 12:19 AM
This revision was automatically updated to reflect the committed changes.
epriestley mentioned this in T10939: Support for OWNERS files.May 14 2016, 1:02 AM
epriestley mentioned this in T5000: Using Differential with plain Git, without requiring Arc.May 20 2016, 11:04 PM

Revision Contents
Changeset List

Diff 38316

View Options

src/applications/metamta/query/PhabricatorMetaMTAMemberQuery.php

Loading...
View Options

src/applications/metamta/replyhandler/PhabricatorMailTarget.php

Loading...
View Options

src/applications/metamta/typeahead/PhabricatorMetaMTAMailableDatasource.php

Loading...
View Options

src/applications/owners/controller/PhabricatorOwnersPathsController.php

Loading...
View Options

src/applications/owners/editor/PhabricatorOwnersPackageEditEngine.php

Loading...
View Options

src/applications/owners/editor/PhabricatorOwnersPackageTransactionEditor.php

Loading...
View Options

src/applications/owners/phid/PhabricatorOwnersPackagePHIDType.php

Loading...
View Options

src/applications/owners/query/PhabricatorOwnersPackageSearchEngine.php

Loading...
View Options

src/applications/owners/storage/PhabricatorOwnersPackage.php

Loading...
View Options

src/applications/owners/typeahead/PhabricatorOwnersPackageDatasource.php

Loading...
Phabricator · Built by Phacility