Differential D15887

Tailor Diffusion protocol rules slightly
ClosedPublic
Actions

Authored by epriestley on May 11 2016, 2:03 PM.

Details

Reviewers

chad

Maniphest Tasks

T10923: Diffusion API/URI Errata
T10948: Hide non-functional clone URLs

Commits

rP5587d97a7f0c: Tailor Diffusion protocol rules slightly

Summary

Fixes T10948. Ref T10923. Make these rules a little more thorough and document their behavior.

Test Plan

Looked at Diffusion clone URIs.

Diff Detail

Repository

rP Phabricator

Branch

dxdoc14

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 12142
Build 15316: Run Core Tests
Build 15315: arc lint + arc unit

Event Timeline

epriestley updated this revision to Diff 38268.May 11 2016, 2:03 PM

epriestley retitled this revision from to Tailor Diffusion protocol rules slightly.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: chad.

epriestley added tasks: T10948: Hide non-functional clone URLs, T10923: Diffusion API/URI Errata.

chad accepted this revision.May 11 2016, 2:12 PM

chad edited edge metadata.

This revision is now accepted and ready to land.May 11 2016, 2:12 PM

Use a more "conventional" spelling of "these".

Closed by commit rP5587d97a7f0c: Tailor Diffusion protocol rules slightly (authored by epriestley, committed by epriestley). · Explain WhyMay 11 2016, 2:18 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

repository/

storage/

PhabricatorRepository.php

4 lines

docs/

user/

userguide/

diffusion_uris.diviner

26 lines

Diff 38268

View Options

src/applications/repository/storage/PhabricatorRepository.php